From 25c31a75d97dabcb2fdb42e5f7b3fb4fd6662bf8 Mon Sep 17 00:00:00 2001 From: Jesse Weinstein Date: Sat, 2 Jan 2016 23:23:36 -0800 Subject: [PATCH] Avoid re-assigning command variable, for clarity --- beets/util/__init__.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/beets/util/__init__.py b/beets/util/__init__.py index 27dbbcd3b..584eb2e8a 100644 --- a/beets/util/__init__.py +++ b/beets/util/__init__.py @@ -779,16 +779,17 @@ def interactive_open(targets, command): if command: # Split the command string into its arguments. try: - command = shlex_split(command) + args = shlex_split(command) except ValueError: # Malformed shell tokens. - command = [command] + args = [command] else: - command = [open_anything()] - command.insert(0, command[0]) # for argv[0] + args = [open_anything()] - command += targets + args.insert(0, args[0]) # for argv[0] - return os.execlp(*command) + args += targets + + return os.execlp(*args) def _windows_long_path_name(short_path):