Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-24 01:25:47 +01:00
Code Issues Projects Releases Wiki Activity

refactoring according to suggestions in pull request

Browse source
This commit is contained in:
Bart Kleijngeld 2017-06-12 17:02:41 +02:00
parent 53d0421d43
commit 24658989da
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
beets/importer.py
View file

@ -537,15 +537,14 @@ class ImportTask(BaseImportTask):
"""Sets the fields given at CLI or configuration to the specified
values.
"""
set_fields_dict = config['import']['set_fields']
for field in set_fields_dict.keys():
value = set_fields_dict[field].get()
for field, view in config['import']['set_fields'].items():
value = view.get()
log.debug(u'Set field {1}={2} for {0}',
displayable_path(self.paths),
field,
value)
self.album[field] = value
self.album.store()
self.album.store()
def finalize(self, session):
"""Save progress, clean up files, and emit plugin event.
@ -898,15 +897,14 @@ class SingletonImportTask(ImportTask):
"""Sets the fields given at CLI or configuration to the specified
values.
"""
set_fields_dict = config['import']['set_fields']
for field in set_fields_dict.keys():
value = set_fields_dict[field].get()
for field, view in config['import']['set_fields'].items():
value = view.get()
log.debug(u'Set field {1}={2} for {0}',
displayable_path(self.paths),
field,
value)
self.item[field] = value
self.item.store()
self.item.store()
# FIXME The inheritance relationships are inverted. This is why there
@ -1418,6 +1416,9 @@ def apply_choice(session, task):
# If ``set_fields`` is set, set those fields to the
# configured values.
# NOTE: This cannot be done before the ``task.add()`` call above,
# because then the ``ImportTask`` won't have an `album` for which
# it can set the fields.
if config['import']['set_fields']:
task.set_fields()