From 2cef0796039a09e2ef1a4454f4612c62a2159cb4 Mon Sep 17 00:00:00 2001 From: malan88 <42282289+malan88@users.noreply.github.com> Date: Thu, 7 Mar 2019 09:39:34 -0500 Subject: [PATCH 1/2] Improve specifications in the matches.ignored setting The setting is quite confusing. After having difficulty getting the autotagger to accept an id for a specific release that I knew was correct, I investigated and count [this closed issue][0] that totally explains the problem. To clarify the issue, I quoted Adrian from the issue and elaborated a bit, providing the solution. Unfortunately, the solution is undocumented. I'd like to document it, but I am unsure what the actual weighting system in `distance_weights` is. Adrian says 0.9 to ignore missing_tracks, which implies it's similar to the distance weighting in the other settings, but other settings in the default config are set to multiples of 1, implying it is not. [0]: https://github.com/beetbox/beets/issues/3064 --- docs/reference/config.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/reference/config.rst b/docs/reference/config.rst index 684dea20c..b3cf84d40 100644 --- a/docs/reference/config.rst +++ b/docs/reference/config.rst @@ -802,6 +802,14 @@ the penalty name to the ``ignored`` setting:: The available penalties are the same as those for the :ref:`max_rec` setting. +Please note: the ignored setting will ignore any *matches* that have the specified penalties. In a sense, it maximizes the listed penalties. It will not ignore *the fact* that those matches have the penalties. For instance, with the above setting, it ignores all matches with missing tracks. It doesn't ignore the fact that there are missing tracks, which would sort of be the opposite. + +To ignore *the penalties themselves* in match selection, add something like the following to your matches settings: + + match: + distance_weights: + missing_tracks: 0.9 + .. _required: required From d1ba56e246e3e8cab0dd458b4a48a6f0c0a26697 Mon Sep 17 00:00:00 2001 From: malan88 <42282289+malan88@users.noreply.github.com> Date: Thu, 7 Mar 2019 10:41:37 -0500 Subject: [PATCH 2/2] Simplify wording, exclude ref to distance_weights Per conversation with Adrian, simplify the wording of the change. --- docs/reference/config.rst | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/docs/reference/config.rst b/docs/reference/config.rst index b3cf84d40..1a461bae7 100644 --- a/docs/reference/config.rst +++ b/docs/reference/config.rst @@ -802,13 +802,7 @@ the penalty name to the ``ignored`` setting:: The available penalties are the same as those for the :ref:`max_rec` setting. -Please note: the ignored setting will ignore any *matches* that have the specified penalties. In a sense, it maximizes the listed penalties. It will not ignore *the fact* that those matches have the penalties. For instance, with the above setting, it ignores all matches with missing tracks. It doesn't ignore the fact that there are missing tracks, which would sort of be the opposite. - -To ignore *the penalties themselves* in match selection, add something like the following to your matches settings: - - match: - distance_weights: - missing_tracks: 0.9 +For example, setting ``ignored: missing_tracks`` will skip any album matches where your audio files are missing some of the tracks. The importer will not attempt to display these matches. It does not ignore the fact that the album is missing tracks, which would allow these matches to apply more easily. To do that, you'll want to adjust the penalty for missing tracks. .. _required: