From d5f998b3120c8027986b55b9288b530fbf165fcc Mon Sep 17 00:00:00 2001 From: wisp3rwind <17089248+wisp3rwind@users.noreply.github.com> Date: Sun, 18 Dec 2022 08:41:42 +0100 Subject: [PATCH] tests: fix assertions for empty MediaFile.images used to work due to inconsistent mediafile implementation, but with https://github.com/beetbox/mediafile/pull/64 (in mediafile >= 0.11.0) list fields are None if non-existent, not the empty list --- test/test_embedart.py | 4 ++-- test/test_zero.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_embedart.py b/test/test_embedart.py index f41180ec1..6cf5bfa56 100644 --- a/test/test_embedart.py +++ b/test/test_embedart.py @@ -82,7 +82,7 @@ class EmbedartCliTest(_common.TestCase, TestHelper): self.run_command('embedart', '-f', self.small_artpath) mediafile = MediaFile(syspath(item.path)) # make sure that images array is empty (nothing embedded) - self.assertEqual(len(mediafile.images), 0) + self.assertFalse(mediafile.images) def test_embed_art_from_file(self): self._setup_data() @@ -203,7 +203,7 @@ class EmbedartCliTest(_common.TestCase, TestHelper): self.io.addinput('y') self.run_command('clearart') mediafile = MediaFile(syspath(item.path)) - self.assertEqual(len(mediafile.images), 0) + self.assertFalse(mediafile.images) def test_clear_art_with_no_input(self): self._setup_data() diff --git a/test/test_zero.py b/test/test_zero.py index c4c176960..b48367b41 100644 --- a/test/test_zero.py +++ b/test/test_zero.py @@ -103,7 +103,7 @@ class ZeroPluginTest(unittest.TestCase, TestHelper): item.write() mf = MediaFile(syspath(path)) - self.assertEqual(0, len(mf.images)) + self.assertFalse(mf.images) def test_auto_false(self): self.config['zero']['fields'] = ['year']