From 17ec5909edbd12b8c2be527404fc71086ee344b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0ar=C5=ABnas=20Nejus?= Date: Mon, 10 Jun 2024 03:20:30 +0100 Subject: [PATCH] Revert "Simplify workflow" This reverts commit 4550d39d1e7833557e863de18163f5a4b80db977. I love this attempt to DRY-up the linting workflow! I remember back in the day also initially assuming that this is how the jobs work. However, I had to meet the harsh reality of each job needing to be set up from zero. :( --- .github/workflows/lint.yml | 51 ++++++++++++++++++++++++++++---------- 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index c65eeda3f..f9af0edb6 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -35,9 +35,11 @@ jobs: files: | **.py - python-setup: + format: + if: needs.changed-files.outputs.any_python_changed == 'true' runs-on: ubuntu-latest - name: Setup python and poetry + name: Check formatting + needs: changed-files steps: - uses: actions/checkout@v4 - name: Install Python tools @@ -47,15 +49,8 @@ jobs: cache: poetry - uses: abatilo/actions-poetry@v2 - name: Install dependencies - run: poetry install --all-extras - + run: poetry install --only=format - format: - if: needs.changed-files.outputs.any_python_changed == 'true' - runs-on: ubuntu-latest - name: Check formatting - needs: [changed-files, python-setup] - steps: - name: Check code formatting uses: liskin/gh-problem-matcher-wrap@v3 with: @@ -66,8 +61,18 @@ jobs: if: needs.changed-files.outputs.any_python_changed == 'true' runs-on: ubuntu-latest name: Check linting - needs: [changed-files, python-setup] + needs: changed-files steps: + - uses: actions/checkout@v4 + - name: Install Python tools + - uses: actions/setup-python@v5 + with: + python-version: ${{ env.PYTHON_VERSION }} + cache: poetry + - uses: abatilo/actions-poetry@v2 + - name: Install dependencies + run: poetry install --only=lint + - name: Lint code uses: liskin/gh-problem-matcher-wrap@v3 with: @@ -78,8 +83,18 @@ jobs: if: needs.changed-files.outputs.any_python_changed == 'true' runs-on: ubuntu-latest name: Check types with mypy - needs: [changed-files, python-setup] + needs: changed-files steps: + - uses: actions/checkout@v4 + - name: Install Python tools + - uses: actions/setup-python@v5 + with: + python-version: ${{ env.PYTHON_VERSION }} + cache: poetry + - uses: abatilo/actions-poetry@v2 + - name: Install dependencies + run: poetry install --only=typing + - name: Type check code uses: liskin/gh-problem-matcher-wrap@v3 continue-on-error: true @@ -91,8 +106,18 @@ jobs: if: needs.changed-files.outputs.any_docs_changed == 'true' runs-on: ubuntu-latest name: Check docs - needs: [changed-files, python-setup] + needs: changed-files steps: + - uses: actions/checkout@v4 + - name: Install Python tools + - uses: actions/setup-python@v5 + with: + python-version: ${{ env.PYTHON_VERSION }} + cache: poetry + - uses: abatilo/actions-poetry@v2 + - name: Install dependencies + run: poetry install --only=docs + - uses: sphinx-doc/github-problem-matcher@master name: Build docs with: