From d4e615febadb94d246d46c51a6d83da93afc7a1f Mon Sep 17 00:00:00 2001 From: milesial Date: Wed, 24 Oct 2018 19:07:12 +0200 Subject: [PATCH 1/4] Fixed typo in convert when copying cover art --- beetsplug/convert.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/beetsplug/convert.py b/beetsplug/convert.py index d1223596f..ba629c8a5 100644 --- a/beetsplug/convert.py +++ b/beetsplug/convert.py @@ -399,9 +399,8 @@ class ConvertPlugin(BeetsPlugin): util.displayable_path(album.artpath), util.displayable_path(dest)) else: - self._log.info(u'Copying cover art to {0}', - util.displayable_path(album.artpath), - util.displayable_path(dest)) + self._log.info(u'Copying cover art from {0}', + util.displayable_path(album.artpath)) util.copy(album.artpath, dest) def convert_func(self, lib, opts, args): From 0ff884daa7a1b7322cebd9f4e1693ced82a61239 Mon Sep 17 00:00:00 2001 From: milesial Date: Thu, 25 Oct 2018 14:37:20 +0200 Subject: [PATCH 2/4] Added a line in the changelog --- docs/changelog.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/changelog.rst b/docs/changelog.rst index 9ff3a5008..1c21bf834 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -98,6 +98,8 @@ Fixes: * Missing album art file during an update no longer causes a fatal exception (instead, an error is logged and the missing file path is removed from the library). :bug:`3030` + +* Confusing typo when the convert plugin copies the art covers. .. _python-itunes: https://github.com/ocelma/python-itunes From b27dfed1efd28150de2901ec5278c00f0fee6b3f Mon Sep 17 00:00:00 2001 From: milesial Date: Thu, 25 Oct 2018 14:49:08 +0200 Subject: [PATCH 3/4] Added the bug emoji ! --- docs/changelog.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index d08c0732f..61e244310 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -102,8 +102,7 @@ Fixes: tags Thanks to :user:`TaizoSimpson`. :bug:`3501` -* Confusing typo when the convert plugin copies the art covers. - +* Confusing typo when the convert plugin copies the art covers. :bug:`3063` .. _python-itunes: https://github.com/ocelma/python-itunes From d5caae12bdfd1b3c88084d3bb169ad2dc1df69ef Mon Sep 17 00:00:00 2001 From: milesial Date: Thu, 25 Oct 2018 15:29:28 +0200 Subject: [PATCH 4/4] Now logs both the source and the destination --- beetsplug/convert.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/beetsplug/convert.py b/beetsplug/convert.py index ba629c8a5..3c9080d1f 100644 --- a/beetsplug/convert.py +++ b/beetsplug/convert.py @@ -399,8 +399,9 @@ class ConvertPlugin(BeetsPlugin): util.displayable_path(album.artpath), util.displayable_path(dest)) else: - self._log.info(u'Copying cover art from {0}', - util.displayable_path(album.artpath)) + self._log.info(u'Copying cover art from {0} to {1}', + util.displayable_path(album.artpath), + util.displayable_path(dest)) util.copy(album.artpath, dest) def convert_func(self, lib, opts, args):