Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-06 08:39:17 +01:00
Code Issues Projects Releases Wiki Activity

lyrics: Fallback to plain lyrics if synced not available

Browse source
This commit is contained in:
Edgars Supe 2024-01-25 19:19:37 +02:00
parent 755e825928
commit 09360259cc
3 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
beetsplug/lyrics.py
View file

@ -277,7 +277,7 @@ class LRCLib(Backend):
return None return None
if self.config["synced"]: if self.config["synced"]:
return data.get("syncedLyrics") return data.get("syncedLyrics") or data.get("plainLyrics")
return data.get("plainLyrics") return data.get("plainLyrics")

4
docs/changelog.rst
View file

@ -8,6 +8,10 @@ Unreleased
New features: New features:
Bug fixes: Bug fixes:
* :doc:`plugins/lyrics`: LRCLib will fallback to plain lyrics if synced lyrics
are not found and `synced` flag is set to `yes`.
For packagers: For packagers:
Other changes: Other changes:

15
test/plugins/test_lyrics.py
View file

@ -620,6 +620,7 @@ class LRCLibLyricsTest(unittest.TestCase):
mock_get.return_value.json.return_value = mock_response mock_get.return_value.json.return_value = mock_response
mock_get.return_value.status_code = 200 mock_get.return_value.status_code = 200
self.plugin.config["synced"] = False
lyrics = lrclib.fetch("la", "la", "la", 999) lyrics = lrclib.fetch("la", "la", "la", 999)
assert lyrics == mock_response["plainLyrics"] assert lyrics == mock_response["plainLyrics"]
@ -627,6 +628,19 @@ class LRCLibLyricsTest(unittest.TestCase):
lyrics = lrclib.fetch("la", "la", "la", 999) lyrics = lrclib.fetch("la", "la", "la", 999)
assert lyrics == mock_response["syncedLyrics"] assert lyrics == mock_response["syncedLyrics"]
@patch("beetsplug.lyrics.requests.get")
def test_fetch_synced_lyrics_fallback(self, mock_get):
mock_response = {
"syncedLyrics": "",
"plainLyrics": "la la la",
}
mock_get.return_value.json.return_value = mock_response
mock_get.return_value.status_code = 200
self.plugin.config["synced"] = True
lyrics = lrclib.fetch("la", "la", "la", 999)
assert lyrics == mock_response["plainLyrics"]
@patch("beetsplug.lyrics.requests.get") @patch("beetsplug.lyrics.requests.get")
def test_fetch_plain_lyrics(self, mock_get): def test_fetch_plain_lyrics(self, mock_get):
mock_response = { mock_response = {
@ -636,6 +650,7 @@ class LRCLibLyricsTest(unittest.TestCase):
mock_get.return_value.json.return_value = mock_response mock_get.return_value.json.return_value = mock_response
mock_get.return_value.status_code = 200 mock_get.return_value.status_code = 200
self.plugin.config["synced"] = False
lyrics = lrclib.fetch("la", "la", "la", 999) lyrics = lrclib.fetch("la", "la", "la", 999)
assert lyrics == mock_response["plainLyrics"] assert lyrics == mock_response["plainLyrics"]