From fc4d7673d3a5472030dd747e1252d6dcc889b936 Mon Sep 17 00:00:00 2001 From: Serene-Arc <33189705+Serene-Arc@users.noreply.github.com> Date: Fri, 24 Nov 2023 14:27:23 +1000 Subject: [PATCH 1/3] Revert line change behaviour --- beets/ui/commands.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/beets/ui/commands.py b/beets/ui/commands.py index ad4f7821d..824b79e7c 100755 --- a/beets/ui/commands.py +++ b/beets/ui/commands.py @@ -680,10 +680,13 @@ class AlbumChange(ChangeRepresentation): # Save new medium details for future comparison. medium, disctitle = track_info.medium, track_info.disctitle - if config["import"]["detail"]: - # Construct the line tuple for the track. - left, right = self.make_line(item, track_info) + # Construct the line tuple for the track. + left, right = self.make_line(item, track_info) + if left != right: lines.append((left, right)) + else: + if config["import"]["detail"]: + lines.append((left, right)) self.print_tracklist(lines) # Missing and unmatched tracks. From 2892be9892daf41d6e7866331a9cf5f448856130 Mon Sep 17 00:00:00 2001 From: Serene-Arc <33189705+Serene-Arc@users.noreply.github.com> Date: Fri, 24 Nov 2023 15:24:58 +1000 Subject: [PATCH 2/3] Add changelog entry --- docs/changelog.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/changelog.rst b/docs/changelog.rst index 1ff5b59c8..52e7069bf 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -263,6 +263,8 @@ Bug fixes: a null path that can't be removed. * Fix bug where empty artist and title fields would return None instead of an empty list in the discord plugin. :bug:`4973` +* Fix bug regarding displaying tracks that have been changed not being + displayed unless the detail configuration is enabled. For packagers: From 9dd59058fe229ff742310829b624d516ecdca358 Mon Sep 17 00:00:00 2001 From: Serene-Arc <33189705+Serene-Arc@users.noreply.github.com> Date: Fri, 24 Nov 2023 18:10:54 +1000 Subject: [PATCH 3/3] Fix comparison --- beets/ui/commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beets/ui/commands.py b/beets/ui/commands.py index 824b79e7c..439858477 100755 --- a/beets/ui/commands.py +++ b/beets/ui/commands.py @@ -682,7 +682,7 @@ class AlbumChange(ChangeRepresentation): # Construct the line tuple for the track. left, right = self.make_line(item, track_info) - if left != right: + if right["contents"] != "": lines.append((left, right)) else: if config["import"]["detail"]: