From 0131ce263de4d47b7f6f8adaa158ece0f517fe9e Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Sat, 4 Feb 2017 13:42:24 -0600 Subject: [PATCH] badfiles: Better logging and error handling (#2428) --- beetsplug/badfiles.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/beetsplug/badfiles.py b/beetsplug/badfiles.py index 5ab0ae983..64b75ee3b 100644 --- a/beetsplug/badfiles.py +++ b/beetsplug/badfiles.py @@ -44,10 +44,11 @@ class BadFiles(BeetsPlugin): status = e.returncode except OSError as e: if e.errno == errno.ENOENT: - ui.print_(u"command not found: {}".format(cmd[0])) - sys.exit(1) + raise ui.UserError(u"command not found: {}".format(cmd[0])) else: - raise + raise ui.UserError( + u"error invoking {}: {}".format(cmd[0], e) + ) output = output.decode(sys.getfilesystemencoding()) return status, errors, [line for line in output.split("\n") if line] @@ -96,6 +97,7 @@ class BadFiles(BeetsPlugin): ext = os.path.splitext(item.path)[1][1:] checker = self.get_checker(ext) if not checker: + self._log.debug(u"no checker available for {}", ext) continue path = item.path if not isinstance(path, six.text_type):