Backup_Repos/Sonarr
1
0
Fork 0
mirror of https://github.com/Sonarr/Sonarr synced 2026-05-08 13:01:10 +02:00
Code Issues Projects Releases Wiki Activity

Propagate Trakt token refresh failures instead of swallowing exceptions

Browse source
This commit is contained in:
Sean Wilson 2026-04-21 00:54:04 +01:00 committed by GitHub
parent e38a2af1ad
commit 1c09c6005c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
src/NzbDrone.Core/ImportLists/Trakt/TraktImportBase.cs
View file

@ -109,7 +109,7 @@ private string GetUserName(string accessToken)
}
catch (HttpException)
{
_logger.Warn($"Error refreshing trakt access token");
_logger.Warn("Error retrieving Trakt user settings");
}
return null;
@ -125,26 +125,22 @@ private void RefreshToken()
.AddQueryParam("refresh_token", Settings.RefreshToken)
.Build();
try
var response = _httpClient.Get<RefreshRequestResponse>(request);
if (response?.Resource == null)
{
var response = _httpClient.Get<RefreshRequestResponse>(request);
if (response != null && response.Resource != null)
{
var token = response.Resource;
Settings.AccessToken = token.AccessToken;
Settings.Expires = DateTime.UtcNow.AddSeconds(token.ExpiresIn);
Settings.RefreshToken = token.RefreshToken ?? Settings.RefreshToken;
if (Definition.Id > 0)
{
_importListRepository.UpdateSettings((ImportListDefinition)Definition);
}
}
_logger.Warn("Trakt token refresh returned an empty response");
return;
}
catch (HttpException)
var token = response.Resource;
Settings.AccessToken = token.AccessToken;
Settings.Expires = DateTime.UtcNow.AddSeconds(token.ExpiresIn);
Settings.RefreshToken = token.RefreshToken ?? Settings.RefreshToken;
if (Definition.Id > 0)
{
_logger.Warn($"Error refreshing trakt access token");
_importListRepository.UpdateSettings((ImportListDefinition)Definition);
}
}
}