Backup_Repos/Readarr
1
0
Fork 0
mirror of https://github.com/Readarr/Readarr synced 2025-12-16 05:12:42 +01:00
Code Issues Projects Releases Wiki Activity

Fixed: Gracefully handle Goodreads search error

Browse source 
Fixes #897
This commit is contained in:
ta264 2021-03-17 21:35:42 +00:00
parent 1e0e8adc77
commit acb6fc01b3
2 changed files with 44 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
src/NzbDrone.Core.Test/MediaFiles/TrackImport/Identification/CandidateServiceFixture.cs Normal file
View file

@ -0,0 +1,41 @@
using System.Collections.Generic;
using FluentAssertions;
using Moq;
using NUnit.Framework;
using NzbDrone.Core.MediaFiles.BookImport.Identification;
using NzbDrone.Core.MetadataSource;
using NzbDrone.Core.MetadataSource.Goodreads;
using NzbDrone.Core.Parser.Model;
using NzbDrone.Core.Test.Framework;
namespace NzbDrone.Core.Test.MediaFiles.BookImport.Identification
{
[TestFixture]
public class CandidateServiceFixture : CoreTest<CandidateService>
{
[Test]
public void should_not_throw_on_goodreads_exception()
{
Mocker.GetMock<ISearchForNewBook>()
.Setup(s => s.SearchForNewBook(It.IsAny<string>(), It.IsAny<string>()))
.Throws(new GoodreadsException("Bad search"));
var edition = new LocalEdition
{
LocalBooks = new List<LocalBook>
{
new LocalBook
{
FileTrackInfo = new ParsedTrackInfo
{
AuthorTitle = "Author",
BookTitle = "Book"
}
}
}
};
Subject.GetRemoteCandidates(edition).Should().BeEmpty();
}
}
}

6
src/NzbDrone.Core/MediaFiles/BookImport/Identification/CandidateService.cs
View file

@ -4,7 +4,7 @@
using NzbDrone.Common.Extensions;
using NzbDrone.Core.Books;
using NzbDrone.Core.MetadataSource;
using NzbDrone.Core.MetadataSource.SkyHook;
using NzbDrone.Core.MetadataSource.Goodreads;
using NzbDrone.Core.Parser.Model;
namespace NzbDrone.Core.MediaFiles.BookImport.Identification
@ -258,9 +258,9 @@ public List<CandidateEdition> GetRemoteCandidates(LocalEdition localEdition)
}
}
}
catch (SkyHookException e)
catch (GoodreadsException e)
{
_logger.Info(e, "Skipping book due to SkyHook error");
_logger.Info(e, "Skipping book due to Goodreads error");
remoteBooks = new List<Book>();
}