Backup_Repos/Readarr
1
0
Fork 0
mirror of https://github.com/Readarr/Readarr synced 2026-01-07 16:13:05 +01:00
Code Issues Projects Releases Wiki Activity

Fixed DownloadFile when file already exists

Browse source
This commit is contained in:
Taloth Saldono 2019-08-31 21:35:01 +02:00 committed by ta264
parent 3c335d498e
commit 5ef55d2180
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/NzbDrone.Common.Test/Http/HttpClientFixture.cs
View file

@ -300,12 +300,12 @@ public void should_not_download_file_with_error()
{
var file = GetTempFilePath();
Assert.Throws<HttpException>(() => Subject.DownloadFile("https://download.readarr.com/wrongpath", file));
Assert.Throws<WebException>(() => Subject.DownloadFile("https://download.readarr.com/wrongpath", file));
File.Exists(file).Should().BeFalse();
File.Exists(file + ".part").Should().BeFalse();
ExceptionVerification.ExpectedWarns(1);
ExceptionVerification.ExpectedWarns(0);
}
[Test]

7
src/NzbDrone.Common/Http/HttpClient.cs
View file

@ -258,6 +258,11 @@ public void DownloadFile(string url, string fileName, string userAgent = null)
}
stopWatch.Stop();
if (File.Exists(fileName))
{
File.Delete(fileName);
}
File.Move(fileNamePart, fileName);
_logger.Debug("Downloading Completed. took {0:0}s", stopWatch.Elapsed.Seconds);
}
@ -266,7 +271,7 @@ public void DownloadFile(string url, string fileName, string userAgent = null)
if (File.Exists(fileNamePart))
{
File.Delete(fileNamePart);
}
}
}
}