diff --git a/NzbDrone.Core.Test/IndexerTests.cs b/NzbDrone.Core.Test/IndexerTests.cs index e2a14f3bba..47e549b628 100644 --- a/NzbDrone.Core.Test/IndexerTests.cs +++ b/NzbDrone.Core.Test/IndexerTests.cs @@ -596,7 +596,6 @@ public void Wombles_NzbInfoUrl_should_contain_information_string() WithConfiguredIndexers(); const string fileName = "wombles.xml"; - const string expectedString = "nzbdetails"; Mocker.GetMock() .Setup(h => h.DownloadStream(It.IsAny(), It.IsAny())) @@ -635,7 +634,6 @@ public void NzbIndex_NzbInfoUrl_should_contain_information_string() { WithConfiguredIndexers(); - const string fileName = "nzbindex.xml"; const string expectedString = "release"; Mocker.GetMock() diff --git a/NzbDrone.Core/Parser.cs b/NzbDrone.Core/Parser.cs index e6da55dc7a..04bc153cef 100644 --- a/NzbDrone.Core/Parser.cs +++ b/NzbDrone.Core/Parser.cs @@ -220,8 +220,7 @@ private static EpisodeParseResult ParseMatchCollection(MatchCollection matchColl } parsedEpisode = new EpisodeParseResult - { - + { AirDate = new DateTime(airyear, airmonth, airday).Date, }; } diff --git a/NzbDrone.Core/Providers/DiskScanProvider.cs b/NzbDrone.Core/Providers/DiskScanProvider.cs index f51e6e95b6..a780756ab4 100644 --- a/NzbDrone.Core/Providers/DiskScanProvider.cs +++ b/NzbDrone.Core/Providers/DiskScanProvider.cs @@ -206,6 +206,7 @@ public virtual EpisodeFile MoveEpisodeFile(EpisodeFile episodeFile, bool newDown catch (UnauthorizedAccessException ex) { Logger.Debug("Unable to apply folder permissions to: ", newFile.FullName); + Logger.TraceException(ex.Message, ex); } episodeFile.Path = newFile.FullName; diff --git a/NzbDrone.Core/Providers/NewznabProvider.cs b/NzbDrone.Core/Providers/NewznabProvider.cs index f789c973f7..b3eab5b7b6 100644 --- a/NzbDrone.Core/Providers/NewznabProvider.cs +++ b/NzbDrone.Core/Providers/NewznabProvider.cs @@ -140,6 +140,7 @@ public virtual void CheckHostname(string url) catch (Exception ex) { Logger.Error("Invalid address {0}, please correct the site URL.", url); + Logger.TraceException(ex.Message, ex); throw; } diff --git a/NzbDrone.Core/Providers/SignalRProvider.cs b/NzbDrone.Core/Providers/SignalRProvider.cs index 671c8d0586..99d37372b9 100644 --- a/NzbDrone.Core/Providers/SignalRProvider.cs +++ b/NzbDrone.Core/Providers/SignalRProvider.cs @@ -28,11 +28,10 @@ public virtual void UpdateEpisodeStatus(int episodeId, EpisodeStatusType episode EpisodeStatus = episodeStatus.ToString(), Quality = (quality == null ? String.Empty : quality.Quality.ToString()) }); - var test = 0; } catch (Exception ex) { - logger.Trace("Error"); + logger.TraceException("Error", ex); throw; } } diff --git a/NzbDrone.Core/Providers/SmtpProvider.cs b/NzbDrone.Core/Providers/SmtpProvider.cs index e0f831dcc7..025c236578 100644 --- a/NzbDrone.Core/Providers/SmtpProvider.cs +++ b/NzbDrone.Core/Providers/SmtpProvider.cs @@ -61,6 +61,7 @@ public virtual void SendEmail(string subject, string body, bool htmlBody = false catch(Exception ex) { Logger.Error("Error sending email. Subject: {0}", email.Subject); + Logger.TraceException(ex.Message, ex); } } diff --git a/NzbDrone.Services/NzbDrone.Services.Service/Providers/SceneMappingProvider.cs b/NzbDrone.Services/NzbDrone.Services.Service/Providers/SceneMappingProvider.cs index 1ff2519ef3..36daef8b16 100644 --- a/NzbDrone.Services/NzbDrone.Services.Service/Providers/SceneMappingProvider.cs +++ b/NzbDrone.Services/NzbDrone.Services.Service/Providers/SceneMappingProvider.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Web; +using NLog; using NzbDrone.Services.Service.Repository; using Services.PetaPoco; @@ -11,6 +12,8 @@ public class SceneMappingProvider { private readonly IDatabase _database; + private static readonly Logger logger = LogManager.GetCurrentClassLogger(); + public SceneMappingProvider(IDatabase database) { _database = database; @@ -74,6 +77,7 @@ public bool Promote(int mappingId) } catch (Exception ex) { + logger.WarnException("Unable to promote scene mapping", ex); return false; } @@ -93,6 +97,7 @@ public bool PromoteAll() } catch (Exception ex) { + logger.WarnException("Unable to promote all scene mappings", ex); return false; } diff --git a/NzbDrone.Update.Test/NzbDrone.Update.Test.csproj b/NzbDrone.Update.Test/NzbDrone.Update.Test.csproj index 16a00c2c9f..acaa83dece 100644 --- a/NzbDrone.Update.Test/NzbDrone.Update.Test.csproj +++ b/NzbDrone.Update.Test/NzbDrone.Update.Test.csproj @@ -80,11 +80,11 @@ NzbDrone.Common - {CADDFCE0-7509-4430-8364-2074E1EEFCA2} + {caddfce0-7509-4430-8364-2074e1eefca2} NzbDrone.Test.Common - {4CCC53CD-8D5E-4CC4-97D2-5C9312AC2BD7} + {4ccc53cd-8d5e-4cc4-97d2-5c9312ac2bd7} NzbDrone.Update diff --git a/NzbDrone.Web/Controllers/CommandController.cs b/NzbDrone.Web/Controllers/CommandController.cs index bc1b0cf68a..1bfe2ee509 100644 --- a/NzbDrone.Web/Controllers/CommandController.cs +++ b/NzbDrone.Web/Controllers/CommandController.cs @@ -1,4 +1,5 @@ using System.Web.Mvc; +using NLog; using NzbDrone.Core.Jobs; using NzbDrone.Core.Providers; using NzbDrone.Core.Providers.DownloadClients; @@ -21,6 +22,8 @@ public class CommandController : Controller private readonly XbmcProvider _xbmcProvider; private readonly PlexProvider _plexProvider; + private static readonly Logger logger = LogManager.GetCurrentClassLogger(); + public CommandController(JobProvider jobProvider, SabProvider sabProvider, SmtpProvider smtpProvider, TwitterProvider twitterProvider, EpisodeProvider episodeProvider, GrowlProvider growlProvider, @@ -133,6 +136,7 @@ public JsonResult RegisterGrowl(string host, string password) } catch(Exception ex) { + logger.TraceException(ex.Message, ex); return JsonNotificationResult.Oops("Couldn't register and test Growl"); } }