[WIP] Fix issues introduced by recent merges (#114)

* Initial plan

* Fix inconsistent HTTP response codes: PUT endpoints return 200 OK instead of 202 Accepted

Co-authored-by: cheir-mneme <176430037+cheir-mneme@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: cheir-mneme <176430037+cheir-mneme@users.noreply.github.com>
This commit is contained in:
Copilot 2025-12-21 14:50:32 -06:00 committed by GitHub
parent 84425d2b25
commit cf490da7f2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 13 additions and 13 deletions

View file

@ -98,7 +98,7 @@ public ActionResult<CollectionResource> UpdateCollection([FromBody] CollectionRe
var updatedMovie = _collectionService.UpdateCollection(model);
return Accepted(updatedMovie.Id);
return Ok(GetResourceById(updatedMovie.Id));
}
[HttpPut]
@ -148,7 +148,7 @@ public ActionResult UpdateCollections([FromBody] CollectionUpdateResource resour
_commandQueueManager.Push(new RefreshCollectionsCommand());
return Accepted(updated);
return Ok(updated);
}
private IEnumerable<CollectionResource> MapToResource(List<MovieCollection> collections)

View file

@ -42,7 +42,7 @@ public virtual ActionResult<TResource> SaveConfig([FromBody] TResource resource)
_configService.SaveConfigDictionary(dictionary);
return Accepted(resource.Id);
return Ok(GetResourceById(resource.Id));
}
protected abstract TResource ToResource(IConfigService model);

View file

@ -125,7 +125,7 @@ public ActionResult<HostConfigResource> SaveHostConfig([FromBody] HostConfigReso
_userService.Upsert(resource.Username, resource.Password);
}
return Accepted(resource.Id);
return Ok(GetResourceById(resource.Id));
}
}
}

View file

@ -52,7 +52,7 @@ public ActionResult<NamingConfigResource> UpdateNamingConfig([FromBody] NamingCo
_namingConfigService.Save(nameSpec);
return Accepted(resource.Id);
return Ok(GetResourceById(resource.Id));
}
[HttpGet("examples")]

View file

@ -46,7 +46,7 @@ public override ActionResult<UiConfigResource> SaveConfig([FromBody] UiConfigRes
_configFileProvider.SaveConfigDictionary(dictionary);
_configService.SaveConfigDictionary(dictionary);
return Accepted(resource.Id);
return Ok(GetResourceById(resource.Id));
}
protected override UiConfigResource ToResource(IConfigService model)

View file

@ -76,7 +76,7 @@ public ActionResult<ImportListExclusionResource> AddImportListExclusion([FromBod
public ActionResult<ImportListExclusionResource> UpdateImportListExclusion([FromBody] ImportListExclusionResource resource)
{
_importListExclusionService.Update(resource.ToModel());
return Accepted(resource.Id);
return Ok(GetResourceById(resource.Id));
}
[HttpPost("bulk")]

View file

@ -253,7 +253,7 @@ public object SetPropertiesBulk([FromBody] List<MovieFileResource> resources)
var movie = _movieService.GetMovie(movieFiles.First().MovieId);
return Accepted(movieFiles.ConvertAll(f => f.ToResource(movie, _upgradableSpecification, _formatCalculator)));
return Ok(movieFiles.ConvertAll(f => f.ToResource(movie, _upgradableSpecification, _formatCalculator)));
}
[NonAction]

View file

@ -60,7 +60,7 @@ public ActionResult<DelayProfileResource> Update([FromBody] DelayProfileResource
{
var model = resource.ToModel();
_delayProfileService.Update(model);
return Accepted(model.Id);
return Ok(GetResourceById(model.Id));
}
protected override DelayProfileResource GetResourceById(int id)

View file

@ -69,7 +69,7 @@ public ActionResult<QualityProfileResource> Update([FromBody] QualityProfileReso
_qualityProfileService.Update(model);
return Accepted(model.Id);
return Ok(GetResourceById(model.Id));
}
protected override QualityProfileResource GetResourceById(int id)

View file

@ -67,7 +67,7 @@ public ActionResult<ReleaseProfileResource> Update([FromBody] ReleaseProfileReso
_profileService.Update(model);
return Accepted(model.Id);
return Ok(GetResourceById(model.Id));
}
protected override ReleaseProfileResource GetResourceById(int id)

View file

@ -34,7 +34,7 @@ public ActionResult<QualityDefinitionResource> Update([FromBody] QualityDefiniti
{
var model = resource.ToModel();
_qualityDefinitionService.Update(model);
return Accepted(model.Id);
return Ok(GetResourceById(model.Id));
}
protected override QualityDefinitionResource GetResourceById(int id)
@ -56,7 +56,7 @@ public object UpdateMany([FromBody] List<QualityDefinitionResource> resource)
_qualityDefinitionService.UpdateMany(qualityDefinitions);
return Accepted(_qualityDefinitionService.All()
return Ok(_qualityDefinitionService.All()
.ToResource());
}