New: Treat compile warnings as errors

This commit is contained in:
ta264 2019-09-30 21:33:03 +01:00
parent cdf8b1cb5d
commit b0adb2035e
2 changed files with 6 additions and 0 deletions

View file

@ -1,6 +1,8 @@
<Project> <Project>
<!-- Common to all Lidarr Projects --> <!-- Common to all Lidarr Projects -->
<PropertyGroup> <PropertyGroup>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<LidarrRootDir>$(MSBuildThisFileDirectory)..\</LidarrRootDir> <LidarrRootDir>$(MSBuildThisFileDirectory)..\</LidarrRootDir>
<!-- Specifies the type of output --> <!-- Specifies the type of output -->
@ -63,6 +65,7 @@
<Deterministic Condition="$(AssemblyVersion.EndsWith('*'))">False</Deterministic> <Deterministic Condition="$(AssemblyVersion.EndsWith('*'))">False</Deterministic>
</PropertyGroup> </PropertyGroup>
<!-- Set the AssemblyConfiguration attribute for projects --> <!-- Set the AssemblyConfiguration attribute for projects -->
<ItemGroup Condition="'$(LidarrProject)'=='true'"> <ItemGroup Condition="'$(LidarrProject)'=='true'">
<AssemblyAttribute Include="System.Reflection.AssemblyConfigurationAttribute"> <AssemblyAttribute Include="System.Reflection.AssemblyConfigurationAttribute">

View file

@ -51,7 +51,10 @@ public void SendEmail(EmailSettings settings, string subject, string body, bool
private void Send(MailMessage email, string server, int port, bool ssl, NetworkCredential credentials) private void Send(MailMessage email, string server, int port, bool ssl, NetworkCredential credentials)
{ {
//TODO: This is marked obsolete in mono, will not be necessary once we build with net core instead
#pragma warning disable CS0618
var smtp = new SmtpClient(server, port); var smtp = new SmtpClient(server, port);
#pragma warning restore CS0618
smtp.EnableSsl = ssl; smtp.EnableSsl = ssl;
smtp.Credentials = credentials; smtp.Credentials = credentials;