From 8730c26de00fce83130aa5f5c1d91588c89dfad5 Mon Sep 17 00:00:00 2001
From: scphantm <scphantm@gmail.com>
Date: Sun, 13 Oct 2024 10:46:02 -0400
Subject: [PATCH] Remove RetroApplyTags from multiple tables

Removed the RetroApplyTags field from ProviderDefinition, Notifications, Indexers, DownloadClients, and relevant API resources. RetroApplyTags is now exclusively managed within ImportListDefinition.
---
 .../Datastore/Migration/241_add_retroapply_to_importlists.cs  | 3 ---
 src/NzbDrone.Core/ImportLists/ImportListDefinition.cs         | 1 +
 src/NzbDrone.Core/ThingiProvider/ProviderDefinition.cs        | 1 -
 src/Radarr.Api.V3/ProviderResource.cs                         | 4 +---
 4 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/NzbDrone.Core/Datastore/Migration/241_add_retroapply_to_importlists.cs b/src/NzbDrone.Core/Datastore/Migration/241_add_retroapply_to_importlists.cs
index 82396a6529..e92decbc0b 100644
--- a/src/NzbDrone.Core/Datastore/Migration/241_add_retroapply_to_importlists.cs
+++ b/src/NzbDrone.Core/Datastore/Migration/241_add_retroapply_to_importlists.cs
@@ -9,8 +9,5 @@ public class add_retroapply_to_importlists : NzbDroneMigrationBase
     protected override void MainDbUpgrade()
     {
         Alter.Table("ImportLists").AddColumn("RetroApplyTags").AsBoolean().WithDefaultValue(false);
-        Alter.Table("Notifications").AddColumn("RetroApplyTags").AsBoolean().WithDefaultValue(false);
-        Alter.Table("Indexers").AddColumn("RetroApplyTags").AsBoolean().WithDefaultValue(false);
-        Alter.Table("DownloadClients").AddColumn("RetroApplyTags").AsBoolean().WithDefaultValue(false);
     }
 }
diff --git a/src/NzbDrone.Core/ImportLists/ImportListDefinition.cs b/src/NzbDrone.Core/ImportLists/ImportListDefinition.cs
index 277f26eb29..4be4f50638 100644
--- a/src/NzbDrone.Core/ImportLists/ImportListDefinition.cs
+++ b/src/NzbDrone.Core/ImportLists/ImportListDefinition.cs
@@ -16,6 +16,7 @@ public class ImportListDefinition : ProviderDefinition, IEquatable<ImportListDef
         public int QualityProfileId { get; set; }
         public string RootFolderPath { get; set; }
         public bool SearchOnAdd { get; set; }
+        public bool RetroApplyTags { get; set; }
 
         [MemberwiseEqualityIgnore]
         public override bool Enable => Enabled;
diff --git a/src/NzbDrone.Core/ThingiProvider/ProviderDefinition.cs b/src/NzbDrone.Core/ThingiProvider/ProviderDefinition.cs
index 449af4c7ae..a4c5db45b0 100644
--- a/src/NzbDrone.Core/ThingiProvider/ProviderDefinition.cs
+++ b/src/NzbDrone.Core/ThingiProvider/ProviderDefinition.cs
@@ -28,7 +28,6 @@ protected ProviderDefinition()
         public ProviderMessage Message { get; set; }
 
         public HashSet<int> Tags { get; set; }
-        public bool RetroApplyTags { get; set; }
 
         [MemberwiseEqualityIgnore]
         public IProviderConfig Settings
diff --git a/src/Radarr.Api.V3/ProviderResource.cs b/src/Radarr.Api.V3/ProviderResource.cs
index 4cecc4f0b4..6b05a1550a 100644
--- a/src/Radarr.Api.V3/ProviderResource.cs
+++ b/src/Radarr.Api.V3/ProviderResource.cs
@@ -37,7 +37,6 @@ public virtual TProviderResource ToResource(TProviderDefinition definition)
                 ConfigContract = definition.ConfigContract,
                 Message = definition.Message,
                 Tags = definition.Tags,
-                RetroApplyTags = definition.RetroApplyTags,
                 Fields = SchemaBuilder.ToSchema(definition.Settings),
 
                 // radarr/supported is an disambiguation page. the # should be a header on the page with appropriate details/link
@@ -62,8 +61,7 @@ public virtual TProviderDefinition ToModel(TProviderResource resource, TProvider
                 Implementation = resource.Implementation,
                 ConfigContract = resource.ConfigContract,
                 Message = resource.Message,
-                Tags = resource.Tags,
-                RetroApplyTags = resource.RetroApplyTags,
+                Tags = resource.Tags
             };
 
             var configContract = ReflectionExtensions.CoreAssembly.FindTypeByName(definition.ConfigContract);