Backup_Repos/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2026-01-24 16:32:41 +01:00
Code Issues Projects Releases Wiki Activity

fix(security): prevent path traversal and command injection (#102)

Browse source 
Co-authored-by: admin <admin@ardentleatherworks.com>
This commit is contained in:
Cody Kickertz 2025-12-21 12:21:31 -06:00 committed by GitHub
parent 9d7b5b5298
commit 80912b7d43
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/NzbDrone.Common/ServiceProvider.cs
View file

@ -184,9 +184,9 @@ public void Start(string serviceName)
public void Restart(string serviceName)
{
var args = string.Format("/C net.exe stop \"{0}\" && net.exe start \"{0}\"", serviceName);
_processProvider.Start("cmd.exe", args);
_logger.Info("Restarting {0} Service...", serviceName);
Stop(serviceName);
Start(serviceName);
}
public void SetPermissions(string serviceName)

12
src/Radarr.Http/Frontend/Mappers/BackupFileMapper.cs
View file

@ -19,7 +19,17 @@ public override string Map(string resourceUrl)
{
var path = resourceUrl.Replace("/backup/", "").Replace('/', Path.DirectorySeparatorChar);
return Path.Combine(_backupService.GetBackupFolder(), path);
var basePath = Path.GetFullPath(_backupService.GetBackupFolder());
var filePath = Path.GetFullPath(Path.Combine(basePath, path));
// Prevent path traversal - ensure path stays within backup folder
if (!filePath.StartsWith(basePath + Path.DirectorySeparatorChar) &&
!filePath.Equals(basePath, System.StringComparison.Ordinal))
{
return null;
}
return filePath;
}
public override bool CanHandle(string resourceUrl)