From 6a4fb133b51eb44e9cf793c4a78161900630c2ea Mon Sep 17 00:00:00 2001
From: admin <admin@ardentleatherworks.com>
Date: Thu, 18 Dec 2025 15:43:56 -0600
Subject: [PATCH] refactor: reduce MyAnonamouseParser cognitive complexity

Extract helper methods for author parsing, title flags, and freeleech
detection to simplify the main ParseResponse loop.

Addresses #30
---
 .../MyAnonamouse/MyAnonamouseParser.cs        | 82 +++++++++++--------
 1 file changed, 48 insertions(+), 34 deletions(-)

diff --git a/src/NzbDrone.Core/Indexers/MyAnonamouse/MyAnonamouseParser.cs b/src/NzbDrone.Core/Indexers/MyAnonamouse/MyAnonamouseParser.cs
index 3910c59d8c..e4d606bafc 100644
--- a/src/NzbDrone.Core/Indexers/MyAnonamouse/MyAnonamouseParser.cs
+++ b/src/NzbDrone.Core/Indexers/MyAnonamouse/MyAnonamouseParser.cs
@@ -72,48 +72,19 @@ public IList<ReleaseInfo> ParseResponse(IndexerResponse indexerResponse)
                 var id = item.Id;
                 var title = item.Title;
 
-                if (item.AuthorInfo != null)
+                var author = ParseAuthorInfo(item);
+                if (author != null)
                 {
-                    try
-                    {
-                        var authorInfo = JsonConvert.DeserializeObject<Dictionary<string, string>>(item.AuthorInfo);
-                        var author = authorInfo?.Take(5).Select(v => v.Value).Join(", ");
-
-                        if (author.IsNotNullOrWhiteSpace())
-                        {
-                            title += " by " + author;
-                        }
-                    }
-                    catch (JsonException ex)
-                    {
-                        _logger.Debug(ex, "Failed to parse author info for torrent {0}", id);
-                    }
+                    title += " by " + author;
                 }
 
-                var flags = new List<string>();
-
-                if (item.LanguageCode.IsNotNullOrWhiteSpace())
-                {
-                    flags.Add(item.LanguageCode);
-                }
-
-                if (item.Filetype.IsNotNullOrWhiteSpace())
-                {
-                    flags.Add(item.Filetype.ToUpper());
-                }
-
-                if (flags.Count > 0)
-                {
-                    title += " [" + flags.Join(" / ") + "]";
-                }
+                title += BuildTitleFlags(item);
 
                 if (item.Vip)
                 {
                     title += " [VIP]";
                 }
 
-                var isFreeLeech = item.Free || item.PersonalFreeLeech || item.FreeVip;
-
                 torrentInfos.Add(new TorrentInfo
                 {
                     Guid = $"MyAnonamouse-{id}",
@@ -124,7 +95,7 @@ public IList<ReleaseInfo> ParseResponse(IndexerResponse indexerResponse)
                     Seeders = item.Seeders,
                     Peers = item.Leechers + item.Seeders,
                     PublishDate = ParseDate(item.Added),
-                    IndexerFlags = GetIndexerFlags(isFreeLeech)
+                    IndexerFlags = GetIndexerFlags(IsFreeLeech(item))
                 });
             }
 
@@ -202,5 +173,48 @@ private string GetInfoUrl(int torrentId)
         }
 
         public Action<IDictionary<string, string>, DateTime?> CookiesUpdater { get; set; }
+
+        private string ParseAuthorInfo(MyAnonamouseTorrent item)
+        {
+            if (item.AuthorInfo == null)
+            {
+                return null;
+            }
+
+            try
+            {
+                var authorInfo = JsonConvert.DeserializeObject<Dictionary<string, string>>(item.AuthorInfo);
+                var author = authorInfo?.Take(5).Select(v => v.Value).Join(", ");
+
+                return author.IsNotNullOrWhiteSpace() ? author : null;
+            }
+            catch (JsonException ex)
+            {
+                _logger.Debug(ex, "Failed to parse author info for torrent {0}", item.Id);
+                return null;
+            }
+        }
+
+        private static string BuildTitleFlags(MyAnonamouseTorrent item)
+        {
+            var flags = new List<string>();
+
+            if (item.LanguageCode.IsNotNullOrWhiteSpace())
+            {
+                flags.Add(item.LanguageCode);
+            }
+
+            if (item.Filetype.IsNotNullOrWhiteSpace())
+            {
+                flags.Add(item.Filetype.ToUpper());
+            }
+
+            return flags.Count > 0 ? " [" + flags.Join(" / ") + "]" : string.Empty;
+        }
+
+        private static bool IsFreeLeech(MyAnonamouseTorrent item)
+        {
+            return item.Free || item.PersonalFreeLeech || item.FreeVip;
+        }
     }
 }