Backup_Repos/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2026-05-07 06:21:00 +02:00
Code Issues Projects Releases Wiki Activity

Fix: Return empty Freebox task list instead of null

Browse source
This commit is contained in:
Marius Michaud 2026-03-07 18:17:13 +01:00
parent 89110c2cc8
commit 64796e38ec
2 changed files with 69 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
src/NzbDrone.Core.Test/Download/DownloadClientTests/FreeboxDownloadTests/FreeboxDownloadProxyFixture.cs Normal file
View file

@ -0,0 +1,68 @@
using System;
using System.Net;
using System.Text;
using FluentAssertions;
using Moq;
using NUnit.Framework;
using NzbDrone.Common.Cache;
using NzbDrone.Common.Http;
using NzbDrone.Core.Download.Clients.FreeboxDownload;
using NzbDrone.Core.Test.Framework;
namespace NzbDrone.Core.Test.Download.DownloadClientTests.FreeboxDownloadTests
{
[TestFixture]
public class FreeboxDownloadProxyFixture : CoreTest<FreeboxDownloadProxy>
{
protected FreeboxDownloadSettings _settings;
protected string _cachedHeaderKeyValue;
protected byte[] _successfulEmptyResponseBytes;
protected Mock<ICached<string>> _cachedHeaderKey;
[SetUp]
public void Setup()
{
_settings = new FreeboxDownloadSettings()
{
Host = "127.0.0.1",
Port = 443,
ApiUrl = "/api/v1/",
AppId = "someid",
AppToken = "S0mEv3RY1oN9T0k3n"
};
_cachedHeaderKeyValue = "abcdefg123456";
var rawSuccessfulEmptyResponse = "{ \"success\": true }";
_successfulEmptyResponseBytes = Encoding.UTF8.GetBytes(rawSuccessfulEmptyResponse);
_cachedHeaderKey = Mocker.GetMock<ICached<string>>();
Mocker.GetMock<ICacheManager>()
.Setup(c => c.GetCache<string>(It.IsAny<Type>(), It.IsAny<string>()))
.Returns(_cachedHeaderKey.Object);
}
protected void GivenCachedHeaderKey()
{
_cachedHeaderKey.Setup(c => c.Find(It.IsAny<string>()))
.Returns<string>(r => _cachedHeaderKeyValue);
}
protected void GivenSuccessfulEmptyResponse()
{
Mocker.GetMock<IHttpClient>()
.Setup(s => s.Execute(It.IsAny<HttpRequest>()))
.Returns<HttpRequest>(r => new HttpResponse(r, new HttpHeader(), _successfulEmptyResponseBytes, statusCode: HttpStatusCode.OK));
}
[Test]
public void GetTasks_WithSuccessfulEmptyResponse_ShouldBeEmpty()
{
GivenCachedHeaderKey();
GivenSuccessfulEmptyResponse();
Subject.GetTasks(_settings).Should().BeEmpty();
}
}
}

2
src/NzbDrone.Core/Download/Clients/FreeboxDownload/FreeboxDownloadProxy.cs
View file

@ -110,7 +110,7 @@ public List<FreeboxDownloadTask> GetTasks(FreeboxDownloadSettings settings)
{
var request = BuildRequest(settings).Resource("/downloads/").Build();
return ProcessRequest<List<FreeboxDownloadTask>>(request, settings).Result;
return ProcessRequest<List<FreeboxDownloadTask>>(request, settings).Result ?? new ();
}
private static string BuildCachedHeaderKey(FreeboxDownloadSettings settings)