From 4c6f80b308dd923df6f6c8e060492044b64fcd3f Mon Sep 17 00:00:00 2001 From: Mark McDowall Date: Thu, 7 Nov 2024 21:55:10 -0800 Subject: [PATCH] Fixed: Closing on click outside select input and styling on Library Import (cherry picked from commit 3e99917e9d2ba486355e80ccba9e199f73a4f5af) --- .../ImportMovie/Import/ImportMovieFooter.css | 10 +--------- .../Form/Select/EnhancedSelectInput.tsx | 18 +++++++++++------- 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/frontend/src/AddMovie/ImportMovie/Import/ImportMovieFooter.css b/frontend/src/AddMovie/ImportMovie/Import/ImportMovieFooter.css index 415155274e..d0c6e98ae5 100644 --- a/frontend/src/AddMovie/ImportMovie/Import/ImportMovieFooter.css +++ b/frontend/src/AddMovie/ImportMovie/Import/ImportMovieFooter.css @@ -1,18 +1,10 @@ .inputContainer { margin-right: 20px; min-width: 150px; - - div { - margin-top: 10px; - - &:first-child { - margin-top: 0; - } - } } .label { - margin-bottom: 3px; + margin-bottom: 10px; font-weight: bold; } diff --git a/frontend/src/Components/Form/Select/EnhancedSelectInput.tsx b/frontend/src/Components/Form/Select/EnhancedSelectInput.tsx index 8c8458145d..5ae1753571 100644 --- a/frontend/src/Components/Form/Select/EnhancedSelectInput.tsx +++ b/frontend/src/Components/Form/Select/EnhancedSelectInput.tsx @@ -230,18 +230,12 @@ function EnhancedSelectInput, V>( }, [handleWindowClick]); const handlePress = useCallback(() => { - if (isOpen) { - removeListener(); - } else { - addListener(); - } - if (!isOpen && onOpen) { onOpen(); } setIsOpen(!isOpen); - }, [isOpen, setIsOpen, addListener, removeListener, onOpen]); + }, [isOpen, setIsOpen, onOpen]); const handleSelect = useCallback( (newValue: ArrayElement) => { @@ -408,6 +402,16 @@ function EnhancedSelectInput, V>( } }); + useEffect(() => { + if (isOpen) { + addListener(); + } else { + removeListener(); + } + + return removeListener; + }, [isOpen, addListener, removeListener]); + return (