Backup_Repos/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2025-12-06 16:32:36 +01:00
Code Issues Projects Releases Wiki Activity

New: Don't treat 400 responses from Notifiarr as errors

Browse source 
(cherry picked from commit 5eb420bbe12f59d0a5392abf3d351be28ca210e6)

Closes #9194
This commit is contained in:
Mark McDowall 2023-09-17 23:56:17 -07:00 committed by Bogdan
parent ea8f5c7b9f
commit 49dac0ebaa
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/NzbDrone.Core/Notifications/Notifiarr/NotifiarrProxy.cs
View file

@ -1,4 +1,5 @@
using System.Net.Http; using System.Net.Http;
using NLog;
using NzbDrone.Common.Http; using NzbDrone.Common.Http;
using NzbDrone.Common.Serializer; using NzbDrone.Common.Serializer;
using NzbDrone.Core.Notifications.Webhook; using NzbDrone.Core.Notifications.Webhook;
@ -14,10 +15,12 @@ public class NotifiarrProxy : INotifiarrProxy
{ {
private const string URL = "https://notifiarr.com"; private const string URL = "https://notifiarr.com";
private readonly IHttpClient _httpClient; private readonly IHttpClient _httpClient;
private readonly Logger _logger;
public NotifiarrProxy(IHttpClient httpClient) public NotifiarrProxy(IHttpClient httpClient, Logger logger)
{ {
_httpClient = httpClient; _httpClient = httpClient;
_logger = logger;
} }
public void SendNotification(WebhookPayload payload, NotifiarrSettings settings) public void SendNotification(WebhookPayload payload, NotifiarrSettings settings)
@ -49,7 +52,10 @@ private void ProcessNotification(WebhookPayload payload, NotifiarrSettings setti
case 401: case 401:
throw new NotifiarrException("API key is invalid"); throw new NotifiarrException("API key is invalid");
case 400: case 400:
throw new NotifiarrException("Unable to send notification. Ensure Radarr Integration is enabled & assigned a channel on Notifiarr"); // 400 responses shouldn't be treated as an actual error because it's a misconfiguration
// between Radarr and Notifiarr for a specific event, but shouldn't stop all events.
_logger.Error("HTTP 400 - Unable to send notification. Ensure Radarr Integration is enabled & assigned a channel on Notifiarr");
break;
case 502: case 502:
case 503: case 503:
case 504: case 504: