From 20b82146acc8fbe31f6f27165f4662dfa5d2c32b Mon Sep 17 00:00:00 2001
From: bakerboy448 <55419169+bakerboy448@users.noreply.github.com>
Date: Thu, 30 Oct 2025 23:34:07 -0500
Subject: [PATCH] New: Deprecate Readarr

---
 .../Applications/AddApplicationItem.js        | 26 ++++++++++++++++-
 .../Applications/Applications/Application.js  | 29 ++++++++++++++++++-
 .../EditApplicationModalContent.js            | 29 +++++++++++++++++++
 .../Applications/Lidarr/LidarrV1Proxy.cs      |  2 +-
 .../Applications/Radarr/RadarrV3Proxy.cs      |  2 +-
 .../Applications/Readarr/Readarr.cs           |  1 +
 .../Applications/Readarr/ReadarrV1Proxy.cs    |  2 +-
 .../Applications/Sonarr/SonarrV3Proxy.cs      |  2 +-
 .../Applications/Whisparr/WhisparrV3Proxy.cs  |  2 +-
 src/NzbDrone.Core/Localization/Core/en.json   |  6 ++++
 10 files changed, 94 insertions(+), 7 deletions(-)

diff --git a/frontend/src/Settings/Applications/Applications/AddApplicationItem.js b/frontend/src/Settings/Applications/Applications/AddApplicationItem.js
index bae97990b..3eaac45f6 100644
--- a/frontend/src/Settings/Applications/Applications/AddApplicationItem.js
+++ b/frontend/src/Settings/Applications/Applications/AddApplicationItem.js
@@ -1,14 +1,18 @@
 import PropTypes from 'prop-types';
 import React, { Component } from 'react';
+import Label from 'Components/Label';
 import Button from 'Components/Link/Button';
 import Link from 'Components/Link/Link';
 import Menu from 'Components/Menu/Menu';
 import MenuContent from 'Components/Menu/MenuContent';
-import { sizes } from 'Helpers/Props';
+import { kinds, sizes } from 'Helpers/Props';
 import translate from 'Utilities/String/translate';
 import AddApplicationPresetMenuItem from './AddApplicationPresetMenuItem';
 import styles from './AddApplicationItem.css';
 
+const DEPRECATED_APPLICATIONS = ['Readarr'];
+const OBSOLETE_APPLICATIONS = [];
+
 class AddApplicationItem extends Component {
 
   //
@@ -36,6 +40,8 @@ class AddApplicationItem extends Component {
     } = this.props;
 
     const hasPresets = !!presets && !!presets.length;
+    const isDeprecated = DEPRECATED_APPLICATIONS.includes(implementation);
+    const isObsolete = OBSOLETE_APPLICATIONS.includes(implementation);
 
     return (
       <div
@@ -49,6 +55,24 @@ class AddApplicationItem extends Component {
         <div className={styles.overlay}>
           <div className={styles.name}>
             {implementationName}
+            {
+              isDeprecated &&
+                <Label
+                  kind={kinds.WARNING}
+                  title={translate('DeprecatedApplicationMessage', { applicationName: implementationName })}
+                >
+                  {translate('Deprecated')}
+                </Label>
+            }
+            {
+              isObsolete &&
+                <Label
+                  kind={kinds.DANGER}
+                  title={translate('ObsoleteApplicationMessage', { applicationName: implementationName })}
+                >
+                  {translate('Obsolete')}
+                </Label>
+            }
           </div>
 
           <div className={styles.actions}>
diff --git a/frontend/src/Settings/Applications/Applications/Application.js b/frontend/src/Settings/Applications/Applications/Application.js
index 086d39ee1..f2ce84ee6 100644
--- a/frontend/src/Settings/Applications/Applications/Application.js
+++ b/frontend/src/Settings/Applications/Applications/Application.js
@@ -10,6 +10,9 @@ import translate from 'Utilities/String/translate';
 import EditApplicationModalConnector from './EditApplicationModalConnector';
 import styles from './Application.css';
 
+const DEPRECATED_APPLICATIONS = ['Readarr'];
+const OBSOLETE_APPLICATIONS = [];
+
 class Application extends Component {
 
   //
@@ -61,10 +64,13 @@ class Application extends Component {
       syncLevel,
       fields,
       tags,
-      tagList
+      tagList,
+      implementation
     } = this.props;
 
     const applicationUrl = fields.find((field) => field.name === 'baseUrl')?.value;
+    const isDeprecated = DEPRECATED_APPLICATIONS.includes(implementation);
+    const isObsolete = OBSOLETE_APPLICATIONS.includes(implementation);
 
     return (
       <Card
@@ -88,6 +94,26 @@ class Application extends Component {
           }
         </div>
 
+        {
+          isDeprecated &&
+            <Label
+              kind={kinds.WARNING}
+              title={translate('DeprecatedApplicationMessage', { applicationName: implementation })}
+            >
+              {translate('Deprecated')}
+            </Label>
+        }
+
+        {
+          isObsolete &&
+            <Label
+              kind={kinds.DANGER}
+              title={translate('ObsoleteApplicationMessage', { applicationName: implementation })}
+            >
+              {translate('Obsolete')}
+            </Label>
+        }
+
         {
           syncLevel === 'addOnly' &&
             <Label kind={kinds.WARNING}>
@@ -141,6 +167,7 @@ class Application extends Component {
 Application.propTypes = {
   id: PropTypes.number.isRequired,
   name: PropTypes.string.isRequired,
+  implementation: PropTypes.string.isRequired,
   enable: PropTypes.bool.isRequired,
   syncLevel: PropTypes.string.isRequired,
   fields: PropTypes.arrayOf(PropTypes.object).isRequired,
diff --git a/frontend/src/Settings/Applications/Applications/EditApplicationModalContent.js b/frontend/src/Settings/Applications/Applications/EditApplicationModalContent.js
index 00e30cdb7..74ce04f1b 100644
--- a/frontend/src/Settings/Applications/Applications/EditApplicationModalContent.js
+++ b/frontend/src/Settings/Applications/Applications/EditApplicationModalContent.js
@@ -39,6 +39,9 @@ const syncLevelOptions = [
   }
 ];
 
+const DEPRECATED_APPLICATIONS = ['Readarr'];
+const OBSOLETE_APPLICATIONS = [];
+
 function EditApplicationModalContent(props) {
   const {
     advancedSettings,
@@ -60,6 +63,7 @@ function EditApplicationModalContent(props) {
 
   const {
     id,
+    implementation,
     implementationName,
     name,
     syncLevel,
@@ -68,6 +72,9 @@ function EditApplicationModalContent(props) {
     message
   } = item;
 
+  const isDeprecated = DEPRECATED_APPLICATIONS.includes(implementation);
+  const isObsolete = OBSOLETE_APPLICATIONS.includes(implementation);
+
   return (
     <ModalContent onModalClose={onModalClose}>
       <ModalHeader>
@@ -90,6 +97,28 @@ function EditApplicationModalContent(props) {
         {
           !isFetching && !error &&
             <Form {...otherProps}>
+              {
+                isDeprecated &&
+                  <Alert
+                    className={styles.message}
+                    kind={kinds.WARNING}
+                  >
+                    <div>{translate('DeprecatedApplicationTitle', { applicationName: implementationName })}</div>
+                    <div>{translate('DeprecatedApplicationMessage', { applicationName: implementationName })}</div>
+                  </Alert>
+              }
+
+              {
+                isObsolete &&
+                  <Alert
+                    className={styles.message}
+                    kind={kinds.DANGER}
+                  >
+                    <div>{translate('ObsoleteApplicationTitle', { applicationName: implementationName })}</div>
+                    <div>{translate('ObsoleteApplicationMessage', { applicationName: implementationName })}</div>
+                  </Alert>
+              }
+
               {
                 !!message &&
                   <Alert
diff --git a/src/NzbDrone.Core/Applications/Lidarr/LidarrV1Proxy.cs b/src/NzbDrone.Core/Applications/Lidarr/LidarrV1Proxy.cs
index 3cc4114f0..9f87c118f 100644
--- a/src/NzbDrone.Core/Applications/Lidarr/LidarrV1Proxy.cs
+++ b/src/NzbDrone.Core/Applications/Lidarr/LidarrV1Proxy.cs
@@ -159,7 +159,7 @@ private LidarrIndexer ExecuteIndexerRequest(HttpRequest request)
                     case HttpStatusCode.BadRequest:
                         if (ex.Response.Content.Contains("Query successful, but no results in the configured categories were returned from your indexer.", StringComparison.InvariantCultureIgnoreCase))
                         {
-                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: Prowlarr will not sync X Indexer to App");
+                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: https://wiki.servarr.com/prowlarr/faq#prowlarr-will-not-sync-x-indexer-to-app");
                             break;
                         }
 
diff --git a/src/NzbDrone.Core/Applications/Radarr/RadarrV3Proxy.cs b/src/NzbDrone.Core/Applications/Radarr/RadarrV3Proxy.cs
index 3f3053f77..0283652c1 100644
--- a/src/NzbDrone.Core/Applications/Radarr/RadarrV3Proxy.cs
+++ b/src/NzbDrone.Core/Applications/Radarr/RadarrV3Proxy.cs
@@ -172,7 +172,7 @@ private RadarrIndexer ExecuteIndexerRequest(HttpRequest request)
                     case HttpStatusCode.BadRequest:
                         if (ex.Response.Content.Contains("Query successful, but no results in the configured categories were returned from your indexer.", StringComparison.InvariantCultureIgnoreCase))
                         {
-                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: Prowlarr will not sync X Indexer to App");
+                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: https://wiki.servarr.com/prowlarr/faq#prowlarr-will-not-sync-x-indexer-to-app");
                             break;
                         }
 
diff --git a/src/NzbDrone.Core/Applications/Readarr/Readarr.cs b/src/NzbDrone.Core/Applications/Readarr/Readarr.cs
index efcc1eca0..4b9e88bf1 100644
--- a/src/NzbDrone.Core/Applications/Readarr/Readarr.cs
+++ b/src/NzbDrone.Core/Applications/Readarr/Readarr.cs
@@ -14,6 +14,7 @@
 
 namespace NzbDrone.Core.Applications.Readarr
 {
+    [Obsolete("Readarr is deprecated and will be removed in a future version")]
     public class Readarr : ApplicationBase<ReadarrSettings>
     {
         public override string Name => "Readarr";
diff --git a/src/NzbDrone.Core/Applications/Readarr/ReadarrV1Proxy.cs b/src/NzbDrone.Core/Applications/Readarr/ReadarrV1Proxy.cs
index 899ef79b6..440022d15 100644
--- a/src/NzbDrone.Core/Applications/Readarr/ReadarrV1Proxy.cs
+++ b/src/NzbDrone.Core/Applications/Readarr/ReadarrV1Proxy.cs
@@ -146,7 +146,7 @@ private ReadarrIndexer ExecuteIndexerRequest(HttpRequest request)
                     case HttpStatusCode.BadRequest:
                         if (ex.Response.Content.Contains("Query successful, but no results in the configured categories were returned from your indexer.", StringComparison.InvariantCultureIgnoreCase))
                         {
-                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: Prowlarr will not sync X Indexer to App");
+                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: https://wiki.servarr.com/prowlarr/faq#prowlarr-will-not-sync-x-indexer-to-app");
                             break;
                         }
 
diff --git a/src/NzbDrone.Core/Applications/Sonarr/SonarrV3Proxy.cs b/src/NzbDrone.Core/Applications/Sonarr/SonarrV3Proxy.cs
index c0c9f1034..77f852741 100644
--- a/src/NzbDrone.Core/Applications/Sonarr/SonarrV3Proxy.cs
+++ b/src/NzbDrone.Core/Applications/Sonarr/SonarrV3Proxy.cs
@@ -159,7 +159,7 @@ private SonarrIndexer ExecuteIndexerRequest(HttpRequest request)
                     case HttpStatusCode.BadRequest:
                         if (ex.Response.Content.Contains("Query successful, but no results in the configured categories were returned from your indexer.", StringComparison.InvariantCultureIgnoreCase))
                         {
-                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: Prowlarr will not sync X Indexer to App");
+                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: https://wiki.servarr.com/prowlarr/faq#prowlarr-will-not-sync-x-indexer-to-app");
                             break;
                         }
 
diff --git a/src/NzbDrone.Core/Applications/Whisparr/WhisparrV3Proxy.cs b/src/NzbDrone.Core/Applications/Whisparr/WhisparrV3Proxy.cs
index e2ee60524..2a16f7b1f 100644
--- a/src/NzbDrone.Core/Applications/Whisparr/WhisparrV3Proxy.cs
+++ b/src/NzbDrone.Core/Applications/Whisparr/WhisparrV3Proxy.cs
@@ -144,7 +144,7 @@ private WhisparrIndexer ExecuteIndexerRequest(HttpRequest request)
                     case HttpStatusCode.BadRequest:
                         if (ex.Response.Content.Contains("Query successful, but no results in the configured categories were returned from your indexer.", StringComparison.InvariantCultureIgnoreCase))
                         {
-                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: Prowlarr will not sync X Indexer to App");
+                            _logger.Warn(ex, "No Results in configured categories. See FAQ Entry: https://wiki.servarr.com/prowlarr/faq#prowlarr-will-not-sync-x-indexer-to-app");
                             break;
                         }
 
diff --git a/src/NzbDrone.Core/Localization/Core/en.json b/src/NzbDrone.Core/Localization/Core/en.json
index a789c6046..8d07f388f 100644
--- a/src/NzbDrone.Core/Localization/Core/en.json
+++ b/src/NzbDrone.Core/Localization/Core/en.json
@@ -538,6 +538,12 @@
   "NotificationsTelegramSettingsIncludeAppName": "Include {appName} in Title",
   "NotificationsTelegramSettingsIncludeAppNameHelpText": "Optionally prefix message title with {appName} to differentiate notifications from different applications",
   "OAuthPopupMessage": "Pop-ups are being blocked by your browser",
+  "Obsolete": "Obsolete",
+  "ObsoleteApplicationMessage": "{applicationName} is obsolete and has been removed",
+  "ObsoleteApplicationTitle": "{applicationName} is Obsolete",
+  "Deprecated": "Deprecated",
+  "DeprecatedApplicationMessage": "{applicationName} is deprecated and will be removed in a future version",
+  "DeprecatedApplicationTitle": "{applicationName} is Deprecated",
   "Ok": "Ok",
   "OnApplicationUpdate": "On Application Update",
   "OnApplicationUpdateHelpText": "On Application Update",