Allow Obsolete of C# Indexer Implementations

src/NzbDrone.Core/HealthCheck/Checks/OutdatedDefinitionCheck.cs

@@ -27,7 +27,8 @@ public override HealthCheck Check()
         {
             var blocklist = _indexerDefinitionUpdateService.GetBlocklist();
 
-            var oldIndexers = _indexerFactory.All().Where(i => i.Implementation == "Cardigann" && blocklist.Contains(((CardigannSettings)i.Settings).DefinitionFile)).ToList();
+            var oldIndexers = _indexerFactory.AllProviders(false)
+                    .Where(i => i.IsObsolete() || (i.Definition.Implementation == "Cardigann" && blocklist.Contains(((CardigannSettings)i.Definition.Settings).DefinitionFile))).ToList();
 
             if (oldIndexers.Count == 0)
             {

src/NzbDrone.Core/IndexerVersions/IndexerDefinitionUpdateService.cs

@@ -29,15 +29,11 @@ public class IndexerDefinitionUpdateService : IIndexerDefinitionUpdateService, I
         private const int DEFINITION_VERSION = 3;
         private readonly List<string> _defintionBlocklist = new List<string>()
         {
-            "aither",
             "animeworld",
-            "blutopia",
             "beyond-hd",
             "beyond-hd-oneurl",
             "danishbytes",
-            "desitorrents",
             "hdbits",
-            "shareisland",
             "lat-team"
         };
 

src/NzbDrone.Core/Indexers/Definitions/Aither.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using NLog;
 using NzbDrone.Common.Http;
@@ -7,6 +8,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class Aither : Unit3dBase
     {
         public override string Name => "Aither";

src/NzbDrone.Core/Indexers/Definitions/AnimeWorld.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using NLog;
 using NzbDrone.Common.Http;
@@ -7,6 +8,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class AnimeWorld : Unit3dBase
     {
         public override string Name => "AnimeWorld";

src/NzbDrone.Core/Indexers/Definitions/Blutopia.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using NLog;
 using NzbDrone.Common.Http;
@@ -7,6 +8,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class Blutopia : Unit3dBase
     {
         public override string Name => "Blutopia";

src/NzbDrone.Core/Indexers/Definitions/DesiTorrents.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using NLog;
@@ -8,6 +9,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class DesiTorrents : Unit3dBase
     {
         public override string Name => "DesiTorrents";

src/NzbDrone.Core/Indexers/Definitions/DigitalCore.cs

@@ -20,6 +20,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class DigitalCore : TorrentIndexerBase<DigitalCoreSettings>
     {
         public override string Name => "DigitalCore";

src/NzbDrone.Core/Indexers/Definitions/InternetArchive.cs

@@ -17,6 +17,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class InternetArchive : TorrentIndexerBase<InternetArchiveSettings>
     {
         public override string Name => "Internet Archive";

src/NzbDrone.Core/Indexers/Definitions/Milkie.cs

@@ -15,6 +15,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class Milkie : TorrentIndexerBase<MilkieSettings>
     {
         public override string Name => "Milkie";

src/NzbDrone.Core/Indexers/Definitions/ShareIsland.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using NLog;
 using NzbDrone.Common.Http;
@@ -7,6 +8,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class ShareIsland : Unit3dBase
     {
         public override string Name => "ShareIsland";

src/NzbDrone.Core/Indexers/Definitions/SuperBits.cs

@@ -18,6 +18,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class SuperBits : TorrentIndexerBase<SuperBitsSettings>
     {
         public override string Name => "SuperBits";

src/NzbDrone.Core/Indexers/Definitions/ThePirateBay.cs

@@ -16,6 +16,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class ThePirateBay : TorrentIndexerBase<ThePirateBaySettings>
     {
         public override string Name => "ThePirateBay";

src/NzbDrone.Core/Indexers/Definitions/TorrentLeech.cs

@@ -20,6 +20,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class TorrentLeech : TorrentIndexerBase<TorrentLeechSettings>
     {
         public override string Name => "TorrentLeech";

src/NzbDrone.Core/Indexers/Definitions/TorrentParadiseMl.cs

@@ -18,6 +18,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class TorrentParadiseMl : TorrentIndexerBase<TorrentParadiseMlSettings>
     {
         public override string Name => "TorrentParadiseMl";

src/NzbDrone.Core/Indexers/Definitions/YTS.cs

@@ -18,6 +18,7 @@
 
 namespace NzbDrone.Core.Indexers.Definitions
 {
+    [Obsolete]
     public class YTS : TorrentIndexerBase<YTSSettings>
     {
         public override string Name => "YTS";

src/NzbDrone.Core/Indexers/IIndexer.cs

@@ -27,6 +27,7 @@ public interface IIndexer : IProvider
         Task<IndexerPageableQueryResult> Fetch(BasicSearchCriteria searchCriteria);
 
         Task<byte[]> Download(Uri link);
+        bool IsObsolete();
 
         IndexerCapabilities GetCapabilities();
     }

src/NzbDrone.Core/Indexers/IndexerBase.cs

@@ -45,6 +45,18 @@ public IndexerBase(IIndexerStatusService indexerStatusService, IConfigService co
 
         public Type ConfigContract => typeof(TSettings);
 
+        public bool IsObsolete()
+        {
+            var attributes = GetType().GetCustomAttributes(false);
+
+            foreach (ObsoleteAttribute attribute in attributes.OfType<ObsoleteAttribute>())
+            {
+                return true;
+            }
+
+            return false;
+        }
+
         public virtual ProviderMessage Message => null;
 
         public virtual IEnumerable<ProviderDefinition> DefaultDefinitions

src/NzbDrone.Core/Indexers/IndexerFactory.cs

@@ -147,6 +147,11 @@ public override IEnumerable<IndexerDefinition> GetDefaultDefinitions()
         {
             foreach (var provider in _providers)
             {
+                if (provider.IsObsolete())
+                {
+                    continue;
+                }
+
                 var definitions = provider.DefaultDefinitions
                     .Where(v => v.Name != null && (v.Name != typeof(Cardigann.Cardigann).Name || v.Name != typeof(Newznab.Newznab).Name || v.Name != typeof(Torznab.Torznab).Name));
 

src/NzbDrone.Core/ThingiProvider/IProvider.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using FluentValidation.Results;
 
@@ -11,6 +11,7 @@ public interface IProvider
         ProviderMessage Message { get; }
         IEnumerable<ProviderDefinition> DefaultDefinitions { get; }
         ProviderDefinition Definition { get; set; }
+
         ValidationResult Test();
         object RequestAction(string stage, IDictionary<string, string> query);
     }