Backup_Repos/Lidarr
1
0
Fork 0
mirror of https://github.com/Lidarr/Lidarr synced 2026-03-03 19:12:49 +01:00
Code Issues Projects Releases Wiki Activity

Added additional codecs and more complete error message.

Browse source
This commit is contained in:
Taloth Saldono 2017-07-29 12:33:21 +02:00
parent c7d30ae703
commit 1cb25525ab
4 changed files with 27 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/NzbDrone.Core.Test/MediaFiles/MediaInfo/MediaInfoFormatterTests/FormatAudioCodecFixture.cs
View file

@ -8,6 +8,8 @@ namespace NzbDrone.Core.Test.MediaFiles.MediaInfo.MediaInfoFormatterTests
[TestFixture]
public class FormatAudioCodecFixture : TestBase
{
private static string sceneName = "My.Series.S01E01-Sonarr";
[TestCase("AC-3", "AC3")]
[TestCase("E-AC-3", "EAC3")]
[TestCase("MPEG Audio", "MPEG Audio")]
@ -19,7 +21,7 @@ public void should_format_audio_format(string audioFormat, string expectedFormat
AudioFormat = audioFormat
};
MediaInfoFormatter.FormatAudioCodec(mediaInfoModel).Should().Be(expectedFormat);
MediaInfoFormatter.FormatAudioCodec(mediaInfoModel, sceneName).Should().Be(expectedFormat);
}
[Test]
@ -31,7 +33,7 @@ public void should_return_MP3_for_MPEG_Audio_with_Layer_3_for_the_profile()
AudioProfile = "Layer 3"
};
MediaInfoFormatter.FormatAudioCodec(mediaInfoModel).Should().Be("MP3");
MediaInfoFormatter.FormatAudioCodec(mediaInfoModel, sceneName).Should().Be("MP3");
}
[Test]
@ -42,7 +44,7 @@ public void should_return_AudioFormat_by_default()
AudioFormat = "Other Audio Format"
};
MediaInfoFormatter.FormatAudioCodec(mediaInfoModel).Should().Be(mediaInfoModel.AudioFormat);
MediaInfoFormatter.FormatAudioCodec(mediaInfoModel, sceneName).Should().Be(mediaInfoModel.AudioFormat);
ExceptionVerification.ExpectedErrors(1);
}
}

2
src/NzbDrone.Core/Extras/Metadata/Consumers/Xbmc/XbmcMetadata.cs
View file

@ -265,7 +265,7 @@ public override MetadataFileResult EpisodeMetadata(Series series, EpisodeFile ep
var audio = new XElement("audio");
audio.Add(new XElement("bitrate", episodeFile.MediaInfo.AudioBitrate));
audio.Add(new XElement("channels", episodeFile.MediaInfo.AudioChannels));
audio.Add(new XElement("codec", MediaInfoFormatter.FormatAudioCodec(episodeFile.MediaInfo)));
audio.Add(new XElement("codec", MediaInfoFormatter.FormatAudioCodec(episodeFile.MediaInfo, episodeFile.SceneName)));
audio.Add(new XElement("language", episodeFile.MediaInfo.AudioLanguages));
streamDetails.Add(audio);

23
src/NzbDrone.Core/MediaFiles/MediaInfo/MediaInfoFormatter.cs
View file

@ -40,7 +40,7 @@ public static decimal FormatAudioChannels(MediaInfoModel mediaInfo)
.Sum(s => decimal.Parse(s, CultureInfo.InvariantCulture));
}
public static string FormatAudioCodec(MediaInfoModel mediaInfo)
public static string FormatAudioCodec(MediaInfoModel mediaInfo, string sceneName)
{
var audioFormat = mediaInfo.AudioFormat;
@ -79,7 +79,12 @@ public static string FormatAudioCodec(MediaInfoModel mediaInfo)
return "FLAC";
}
Logger.Error("Unknown audio format: {0}", audioFormat);
if (audioFormat.Equals("Vorbis", StringComparison.OrdinalIgnoreCase))
{
return "Vorbis";
}
Logger.Error(new Exception(), "Unknown audio format: {0} in {1}. Please notify Sonarr developers.", audioFormat, sceneName);
return audioFormat;
}
@ -111,12 +116,22 @@ public static string FormatVideoCodec(MediaInfoModel mediaInfo, string sceneName
return "MPEG2";
}
if (videoCodec.Equals("XviD", StringComparison.OrdinalIgnoreCase))
if (videoCodec.StartsWith("XviD", StringComparison.OrdinalIgnoreCase))
{
return "XviD";
}
Logger.Error("Unknown video codec: {0}", videoCodec);
if (videoCodec.StartsWith("DivX", StringComparison.OrdinalIgnoreCase))
{
return "DivX";
}
if (videoCodec.Equals("VC-1", StringComparison.OrdinalIgnoreCase))
{
return "VC1";
}
Logger.Error(new Exception(), "Unknown video codec: {0} in {1}. Please notify Sonarr developers.", videoCodec, sceneName);
return videoCodec;
}
}

4
src/NzbDrone.Core/Organizer/FileNameBuilder.cs
View file

@ -131,7 +131,7 @@ public string BuildFileName(List<Episode> episodes, Series series, EpisodeFile e
AddEpisodeFileTokens(tokenHandlers, episodeFile);
AddQualityTokens(tokenHandlers, series, episodeFile);
AddMediaInfoTokens(tokenHandlers, episodeFile);
var fileName = ReplaceTokens(pattern, tokenHandlers, namingConfig).Trim();
fileName = FileNameCleanupRegex.Replace(fileName, match => match.Captures[0].Value[0].ToString());
fileName = TrimSeparatorsRegex.Replace(fileName, string.Empty);
@ -455,7 +455,7 @@ private void AddMediaInfoTokens(Dictionary<string, Func<TokenMatch, string>> tok
if (episodeFile.MediaInfo == null) return;
var videoCodec = MediaInfoFormatter.FormatVideoCodec(episodeFile.MediaInfo, episodeFile.SceneName);
var audioCodec = MediaInfoFormatter.FormatAudioCodec(episodeFile.MediaInfo);
var audioCodec = MediaInfoFormatter.FormatAudioCodec(episodeFile.MediaInfo, episodeFile.SceneName);
var audioChannels = MediaInfoFormatter.FormatAudioChannels(episodeFile.MediaInfo);
var mediaInfoAudioLanguages = GetLanguagesToken(episodeFile.MediaInfo.AudioLanguages);