Backup_Repos/Lidarr
1
0
Fork 0
mirror of https://github.com/Lidarr/Lidarr synced 2025-12-06 08:25:54 +01:00
Code Issues Projects Releases Wiki Activity

perf: Fix trace logging of HttpClient responses from blocking the UI and pegging the CPU

Browse source
This commit is contained in:
slydetector 2025-10-18 14:50:51 +00:00
parent 96e5a4df2f
commit 180c6fbe8b
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/NzbDrone.Common/Http/HttpClient.cs
View file

@ -169,7 +169,13 @@ private async Task<HttpResponse> ExecuteRequestAsync(HttpRequest request, Cookie
if (request.LogResponseContent && response.ResponseData != null)
{
_logger.Trace("Response content ({0} bytes): {1}", response.ResponseData.Length, response.Content);
// Logging large response.Content is time consuming, pegs the CPU, and blocks the UI.
// Only evaluate the Trace call when tracing is actually enabled.
// Datapoint: NZBGet history endpoint with 500 items is about 1MB and takes 2m30s to log.
if (_logger.IsTraceEnabled)
{
_logger.Trace("Response content ({0} bytes): {1}", response.ResponseData.Length, response.Content);
}
}
return response;