Commit graph

865 commits

Author SHA1 Message Date
Jim Miller
9f77f3a60d Bump Test Version 4.8.8 2022-01-10 09:09:18 -06:00
Jim Miller
bc149a2deb Bump Test Version 4.8.7 2022-01-04 13:06:16 -06:00
Jim Miller
033c38fc91 Bump Test Version 4.8.6 2021-12-21 12:58:28 -06:00
hseg
a43949d123
Refactor main() in cli.py (#781)
* main: Replace return by explicit calls to exit()

In anticipation of breaking out these sections in their own functions

* Make doc-getting flags shortcut

This saves on pointless validation/setup work when only getting help
information. Moreover, these were the only actions that were in the
middle of the parse/validate/setup/run core logic of main(), moving them
out clears the way to cleanly breaking it up.

Removes -v alias for --version. If this is undesirable, a trick similar
to that for --sites-list can be used to shortcut it as well.

* Move up flag implication logic, var renaming

These are "virtual flags", should be set up asap after actual flags are
setup. Ideally, these would be set up in arg parsing, but this is
sometimes impossible/impractical.

Future improvement: use callbacks to say eg --updatealways sets
options.update, options.updatealways

* Move up validation

Fail fast if the arguments are invalid

* Internalize list_only into options

Helps keep related state together

* Pack up configs, printers for easier passing

* Break up main() into phases

* Remove unnecessary semicolon

* Unbundle configs, printers

This reverts commit 5dd44bbfc3.
Revertion reasons:
1) Initial commit was broken -- it reordered parameters in invocations
   to `get_config()`. This happened because python complained about
   invocations of the form `f(x,**d,z)` -- positional parameters may not
   appear after kwarg expansion. I mistakenly believed kwarg expansion
   would consume the slots of those parameters, and so this code would
   be equivalent to `f(x,z,**d)`. Instead, this passes `z` to the second
   positional parameter, which luckily enough had a key contained in `d`
   so it only caused a TypeError over the multiple values for that
   parameter.
2) To maintain the vision of the original commit would require multiple
   pessimizations *over* the previous state. Specifically:
   1) Using our running example of invocations of the form `f(x,**d,z)`,
      we'd need to turn `z` into a keyword argument. Since Python has no
      way of writing "`z` is a keyword argument whose value is taken
      from the current scope", that forces writing `f(x,**d,z=z)`.
      (Even if a proposal like <https://lwn.net/Articles/818129/> is
      accepted, we wouldn't be able to use it since we need to support
      Python 2)
   2) `dispatch()` uses `fail` internally. So we have one of two
      options:
      * Bundle `warn, fail` in `dispatch`'s arguments, and add a line
        `fail=printers['fail']` to the top of `dispatch`
      * Don't bundle `warn, fail` in `dispatch`'s arguments, and have
        `dispatch` bundle them instead
      Neither of these is palatable, especially over
      * Don't bundle `warn, fail` anywhere

* Restore -v alias for version

As 0847fc9 suggested might be desired
2021-12-21 12:21:02 -06:00
Jim Miller
61bc732810 Bump Test Version 4.8.5 2021-12-19 12:10:54 -06:00
gesh
c0d776f64c cli.py: move out parseArgs
Resolves: #779
2021-12-19 03:48:35 +02:00
Jim Miller
a2dd11326f Bump Test Version 4.8.4 2021-12-14 19:36:34 -06:00
Jim Miller
6fc9aa6dfc Bump Test Version 4.8.3 2021-12-11 19:32:16 -06:00
Jim Miller
80fb72928e Bump Test Version 4.8.2 2021-12-10 10:12:27 -06:00
Jim Miller
89e731031c Bump Test Version 4.8.1 2021-12-03 10:56:46 -06:00
Jim Miller
a2523f1a1e Bump Release Version 4.8.0 2021-12-02 09:33:07 -06:00
Jim Miller
4460ee00cf Bump Test Version 4.7.9 2021-11-28 12:32:17 -06:00
Jim Miller
744400b161 Bump Test Version 4.7.8 2021-11-20 15:24:58 -06:00
Jim Miller
adfaf141d3 Bump Test Version 4.7.7 2021-11-19 20:21:50 -06:00
Jim Miller
b142654dfc Bump Test Version 4.7.6 2021-11-19 10:38:35 -06:00
Jim Miller
cf5c0fd68c Bump Test Version 4.7.5 2021-11-17 12:54:50 -06:00
Jim Miller
2ddce1acd5 Bump Test Version 4.7.4 2021-11-14 11:57:29 -06:00
Jim Miller
df61e88714 Bump Test Version 4.7.3 2021-11-12 19:21:31 -06:00
Jim Miller
a829d01e7c Bump Test Version 4.7.2 2021-11-09 16:47:03 -06:00
Jim Miller
1459ad8611 Add --json-meta-file CLI option. #761 2021-11-09 16:46:56 -06:00
Jim Miller
2e78b153d5 Bump Test Version 4.7.1 2021-11-09 08:54:49 -06:00
Jim Miller
9080349615 Bump Release Version 4.7.0 2021-11-04 12:36:56 -05:00
Jim Miller
2085dda0a3 Bump Test Version 4.6.11 2021-11-03 15:00:56 -05:00
Jim Miller
d7940213ab Bump Test Version 4.6.10 2021-11-01 20:10:02 -05:00
Jim Miller
605fc0dbcf Bump Test Version 4.6.9 2021-10-27 13:35:04 -05:00
Jim Miller
913f8dc256 Bump Test Version 4.6.8 2021-10-25 13:07:59 -05:00
Jim Miller
7ec234a052 Bump Test Version 4.6.7 2021-10-24 09:44:55 -05:00
Jim Miller
120a82c82b Bump Test Version 4.6.6 2021-10-20 13:20:45 -05:00
Jim Miller
9e54b8d82b Bump Test Version 4.6.5 2021-10-16 15:30:53 -05:00
Jim Miller
f4de32550c Bump Test Version 4.6.4 2021-10-10 20:35:14 -05:00
Jim Miller
9dc4de0f07 Bump Test Version 4.6.3 2021-10-10 19:41:16 -05:00
Jim Miller
5e02fdc2ae Bump Test Version 4.6.2 2021-10-07 11:18:57 -05:00
Jim Miller
0a114cd313 Bump Test Version 4.6.1 2021-10-02 17:13:32 -05:00
Jim Miller
76565e959a Bump Release Version 4.6.0 2021-09-30 11:53:56 -05:00
Jim Miller
70e67f7960 Bump Test Version 4.5.15 2021-09-28 12:57:31 -05:00
Jim Miller
0eb3abd44a Bump Test Version 4.5.14 2021-09-27 11:25:46 -05:00
Jim Miller
c92acf2b3b Bump Test Version 4.5.13 2021-09-24 11:23:06 -05:00
Jim Miller
7ac8d1f1aa Bump Test Version 4.5.12 2021-09-24 10:49:35 -05:00
Jim Miller
4dcc9ec510 Bump Test Version 4.5.11 2021-09-23 10:16:01 -05:00
Jim Miller
16f19e6b4a Bump Test Version 4.5.10 2021-09-16 19:09:23 -05:00
Jim Miller
982fd32a06 Bump Test Version 4.5.9 2021-09-16 12:45:30 -05:00
Jim Miller
443a543bb5 Bump Test Version 4.5.8 2021-09-16 12:24:28 -05:00
Jim Miller
52e740cf58 Bump Test Version 4.5.7 2021-09-16 12:24:28 -05:00
Jim Miller
73305fe0df Bump Test Version 4.5.6 2021-09-16 12:24:28 -05:00
Jim Miller
464a7a3ee3 Bump Test Version 4.5.5 2021-09-08 16:40:01 -05:00
Jim Miller
1082dc5417 Bump Test Version 4.5.4 2021-09-07 18:22:37 -05:00
Jim Miller
8ea2aca735 Bump Test Version 4.5.3 2021-09-04 15:11:58 -05:00
Jim Miller
b94779f7d4 Bump Test Version 4.5.2 2021-09-03 11:26:55 -05:00
Jim Miller
3ae3d6c677 Bump Test Version 4.5.1 2021-08-29 15:36:35 -05:00
Jim Miller
5aa8f2b25c Bump Release Version 4.5.0 2021-08-25 09:09:46 -05:00
Jim Miller
72ada92aa4 Bump Test Version 4.4.6 2021-08-20 19:42:22 -05:00
Jim Miller
3a30d2c5ea Bump Test Version 4.4.5 2021-08-09 13:29:33 -05:00
Jim Miller
ca3a453447 Bump Test Version 4.4.4 2021-08-09 12:57:12 -05:00
Jim Miller
3aebb20ec2 Bump Test Version 4.4.3 2021-08-07 08:35:05 -05:00
Jim Miller
0609d8bfae Bump Test Version 4.4.2 2021-07-26 17:06:24 -05:00
Jim Miller
466e706f1c Bump Test Version 4.4.1 2021-07-14 13:09:19 -05:00
Jim Miller
162dcf5fbd Bump Release Version 4.4.0 2021-07-13 11:18:19 -05:00
Jim Miller
4c56c27b3b Bump Test Version 4.3.16 2021-07-12 09:21:21 -05:00
Jim Miller
7a30473ce2 Bump Test Version 4.3.15 2021-07-11 09:12:58 -05:00
Jim Miller
dbba0d5cb2 Bump Test Version 4.3.14 2021-07-10 11:59:46 -05:00
Jim Miller
3063baeb20 Bump Test Version 4.3.13 2021-07-10 11:05:49 -05:00
Jim Miller
7d3c1c1e2b Bump Test Version 4.3.12 2021-07-09 13:00:39 -05:00
Jim Miller
f26bc481d4 Bump Test Version 4.3.11 2021-07-02 10:46:56 -05:00
Jim Miller
7077c85ada Bump Test Version 4.3.10 2021-06-27 11:25:13 -05:00
Jim Miller
f74f1a3561 Bump Test Version 4.3.9 2021-06-27 10:24:47 -05:00
Jim Miller
da800759ca Bump Test Version 4.3.8 2021-06-23 20:08:44 -05:00
Jim Miller
0e4e3ab00a Bump Test Version 4.3.7 2021-06-21 12:18:35 -05:00
Jim Miller
93d11a4b8d Bump Test Version 4.3.6 2021-06-21 11:52:42 -05:00
Jim Miller
e4d198b72b Bump Test Version 4.3.5 2021-06-16 08:56:14 -05:00
Jim Miller
125487003e Bump Test Version 4.3.4 2021-06-15 15:26:03 -05:00
Jim Miller
bccb7eed85 Bump Test Version 4.3.3 2021-06-10 11:05:22 -05:00
Jim Miller
b57094dc5d Bump Test Version 4.3.2 2021-06-03 11:20:34 -05:00
Jim Miller
c26c9be76f Bump Test Version 4.3.1 2021-06-01 10:34:02 -05:00
Jim Miller
9f270e2b91 Bump Release Version 4.3.0 2021-05-30 13:09:12 -05:00
Jim Miller
45ecbf8ede Bump Test Version 4.2.4 2021-05-23 13:18:18 -05:00
Jim Miller
872644cbe6 Bump Test Version 4.2.3 2021-05-13 09:24:14 -05:00
Jim Miller
64759be173 Bump Test Version 4.2.2 2021-05-06 10:44:37 -05:00
Jim Miller
73a4d83eda Bump Test Version 4.2.1 2021-05-04 12:48:13 -05:00
Jim Miller
2a4a09f562 Add CLI --color option for warns and fails. Closes #692 2021-05-04 12:36:11 -05:00
Jim Miller
6d6f273787 Bump Release Version 4.2.0 2021-04-30 08:42:27 -05:00
Jim Miller
c8a695c735 Bump Test Version 4.1.10 2021-04-20 19:15:52 -05:00
Jim Miller
2cd6f53f76 Bump Test Version 4.1.9 2021-04-16 11:17:09 -05:00
Jim Miller
4fb60c0a9c import changes for arch linux system plugins - As submitted by eli-schwartz 2021-04-16 11:16:29 -05:00
Jim Miller
1d3067dfec Bump Test Version 4.1.8 2021-04-15 13:28:13 -05:00
Jim Miller
867f3fdb49 Bump Test Version 4.1.7 2021-04-14 19:25:34 -05:00
Jim Miller
1bfa1bc62b Bump Test Version 4.1.6 2021-04-12 19:19:00 -05:00
Jim Miller
f139e6ea94 Bump Test Version 4.1.5 2021-04-04 10:04:56 -05:00
Jim Miller
3e73f6c708 Bump Test Version 4.1.4 2021-04-01 12:32:06 -05:00
Jim Miller
e16694a798 Bump Test Version 4.1.3 2021-03-31 11:40:53 -05:00
Jim Miller
d10c357036 Bump Test Version 4.1.2 2021-03-29 17:01:52 -05:00
Jim Miller
dd75be8efe Bump Test Version 4.1.1 2021-03-28 17:22:56 -05:00
Jim Miller
41ba08d2f6 Bump Release Version 4.1.0 2021-03-26 12:13:57 -05:00
Jim Miller
03b93bb9d7 Bump Test Version 4.0.13 2021-03-21 10:13:53 -05:00
Jim Miller
69b6fcc17b Bump Test Version 4.0.12 2021-03-20 09:07:05 -05:00
Jim Miller
824e33abcd Bump Test Version 4.0.11 2021-03-19 12:52:48 -05:00
Jim Miller
f324c284ff Bump Test Version 4.0.10 2021-03-13 12:42:48 -06:00
Jim Miller
7bc0be1788 Bump Test Version 4.0.9 2021-03-11 13:52:08 -06:00
Jim Miller
35e10c0a8b Bump Test Version 4.0.8 2021-03-11 11:21:31 -06:00
Jim Miller
ba50bff441 Bump Test Version 4.0.7 2021-03-09 12:26:50 -06:00
Jim Miller
97dabcfceb Bump Test Version 4.0.6 2021-03-06 17:17:44 -06:00
Jim Miller
e1ff7e9739 Bump Test Version 4.0.5 2021-03-02 09:19:08 -06:00
Jim Miller
158b4b7553 Bump Test Version 4.0.4 2021-02-25 13:04:46 -06:00
Jim Miller
494e3fbaaa Bump Test Version 4.0.3 2021-02-22 12:03:37 -06:00
Jim Miller
5ea0a3d140 Bump Test Version 4.0.2 2021-02-20 16:36:06 -06:00
Jim Miller
d9d61a04a8 Bump Test Version 4.0.1 2021-02-20 15:50:36 -06:00
Jim Miller
b1333ad5c2 Bump Release Version 4.0.0 2021-02-18 19:23:50 -06:00
Jim Miller
e6e51fc9fd Bump Test Version 3.99.33 2021-02-17 09:23:05 -06:00
Jim Miller
bc2cea6187 Bump Test Version 3.99.32 2021-02-16 15:25:05 -06:00
Jim Miller
d8daf768a9 Bump Test Version 3.99.31 2021-02-15 17:09:28 -06:00
Jim Miller
aed2c5743f Bump Test Version 3.99.30 2021-02-13 19:16:29 -06:00
Jim Miller
6252203b85 Bump Test Version 3.99.29 2021-02-12 14:04:03 -06:00
Jim Miller
becca6e157 Bump Test Version 3.99.28 2021-02-11 17:26:36 -06:00
Jim Miller
dddf955fae Bump Test Version 3.99.27 2021-02-10 12:39:52 -06:00
Jim Miller
9b6657edb3 Bump Test Version 3.99.26 2021-02-09 20:19:31 -06:00
Jim Miller
61e35f0b53 Bump Test Version 3.99.25 2021-02-09 19:59:17 -06:00
Jim Miller
760a5cbc9c Bump Test Version 3.99.24 2021-02-09 17:55:38 -06:00
Jim Miller
3f43e5b929 Bump Test Version 3.99.23 2021-02-09 13:26:38 -06:00
Jim Miller
34608575c7 Bump Test Version 3.99.22 2021-02-08 16:02:34 -06:00
Jim Miller
212d076a50 Bump Test Version 3.99.21 2021-02-08 14:29:52 -06:00
Jim Miller
797dc6e420 Bump Test Version 3.99.20 2021-02-07 15:27:32 -06:00
Jim Miller
c294446082 Bump Test Version 3.99.19 2021-02-05 13:11:57 -06:00
Jim Miller
c1ae854548 Bump Test Version 3.99.18 2021-02-04 14:30:09 -06:00
Jim Miller
312179570b Bump Test Version 3.99.17 2021-02-03 19:18:52 -06:00
Jim Miller
8506ed9b5b Bump Test Version 3.99.16 2021-02-03 13:43:17 -06:00
Jim Miller
5ee4a2e572 Browser cache sharing in CLI, but not plugin. 2021-02-03 12:18:03 -06:00
Jim Miller
5f4504ccf2 Bump Test Version 3.99.15 2021-02-03 10:51:49 -06:00
Jim Miller
5ab1779b4c Need newer requests/urllib3 for Retry(other=) 2021-02-03 10:51:26 -06:00
Jim Miller
badfc73fcb Bump Test Version 3.99.12 2021-02-03 09:13:04 -06:00
Jim Miller
0fa4dfda3f Bump Test Version 3.99.11 2021-02-03 09:09:09 -06:00
Jim Miller
c2afc72d6c Bump Test Version 3.99.10 2021-02-03 08:52:07 -06:00
Jim Miller
886e37b168 Bump Test Version 3.99.9 2021-02-02 17:35:05 -06:00
Jim Miller
9f13145b2c Still only for ffnet, but browser cache now saves the newest entry and other improvements. 2021-02-02 17:34:58 -06:00
Jim Miller
af241ca42c Make CLI chapter errors report more noticable. 2021-02-02 16:39:06 -06:00
Jim Miller
3e4193a6d5 Bump Test Version 3.99.8 2021-02-01 20:05:34 -06:00
Jim Miller
eb04b3b7e4 Rename pagecache basic_cache. 2021-02-01 17:50:10 -06:00
Jim Miller
c0d283b9c2 Bump Test Version 3.99.7 2021-01-31 15:38:24 -06:00
Jim Miller
6bcf0f5499 Bump Test Version 3.99.6 2021-01-31 14:34:06 -06:00
Jim Miller
e3217dfed6 Bump Test Version 3.99.5 2021-01-31 11:45:30 -06:00
Jim Miller
fad21498d2 Bump Test Version 3.99.4 2021-01-31 10:48:35 -06:00
Jim Miller
e380560cb3 'Remove' unsupported --unverified_ssl CLI option. Use use_ssl_unverified_context:true 2021-01-31 10:38:29 -06:00
Jim Miller
03ebc65f6b Refactor autosave cookie/cache in CLI, etc. 2021-01-31 10:32:42 -06:00
Jim Miller
b1c2fe6885 Bump Test Version 3.99.3 2021-01-31 09:55:07 -06:00
Jim Miller
3c20a4c247 BasicCache save/load working. 2021-01-31 09:53:42 -06:00
Jim Miller
ddf82749af Bump Test Version 3.99.1 2021-01-29 13:41:11 -06:00
Jim Miller
3f6793b301 Refactor sleep and progressbar into FetcherDecorators 2021-01-29 13:30:49 -06:00
Jim Miller
eb63b8bae5 Refactor cookiejar into Fetcher. 2021-01-28 17:41:33 -06:00
Jim Miller
12a7caa667 Bump Test Version 3.99.0 2021-01-25 21:29:28 -06:00
Jim Miller
66520e236c Remove unused imports fanficfare 2021-01-25 20:53:31 -06:00
Jim Miller
f9a1fef55d Bump Test Version 3.29.2 2021-01-23 10:24:56 -06:00
Jim Miller
96d0167538 Bump Test Version 3.29.1 2021-01-20 12:27:50 -06:00