From cbde66cf410dc701bdb2c5c8d41b4971102a0645 Mon Sep 17 00:00:00 2001 From: Jim Miller Date: Mon, 2 Feb 2026 13:12:18 -0600 Subject: [PATCH] adapter_fimfictionnet/adapter_royalroadcom: Better handling of cover image size fall back #1306 --- fanficfare/adapters/adapter_fimfictionnet.py | 3 ++- fanficfare/adapters/adapter_royalroadcom.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fanficfare/adapters/adapter_fimfictionnet.py b/fanficfare/adapters/adapter_fimfictionnet.py index c7def71e..47a4c5ab 100644 --- a/fanficfare/adapters/adapter_fimfictionnet.py +++ b/fanficfare/adapters/adapter_fimfictionnet.py @@ -184,7 +184,8 @@ class FimFictionNetSiteAdapter(BaseSiteAdapter): if storyImage: coverurl = storyImage['data-fullsize'] # try setting from data-fullsize, if fails, try using data-src - if self.setCoverImage(self.url,coverurl)[0].startswith("failedtoload"): + cover_set = self.setCoverImage(self.url,coverurl)[0] + if not cover_set or cover_set.startswith("failedtoload"): coverurl = storyImage['src'] self.setCoverImage(self.url,coverurl) diff --git a/fanficfare/adapters/adapter_royalroadcom.py b/fanficfare/adapters/adapter_royalroadcom.py index 07b58c8e..e3dcc242 100644 --- a/fanficfare/adapters/adapter_royalroadcom.py +++ b/fanficfare/adapters/adapter_royalroadcom.py @@ -289,7 +289,8 @@ class RoyalRoadAdapter(BaseSiteAdapter): if img: cover_url = img['src'] # usually URL is for thumbnail. Try expected URL for larger image, if fails fall back to the original URL - if self.setCoverImage(url,cover_url.replace('/covers-full/', '/covers-large/'))[0].startswith("failedtoload"): + cover_set = self.setCoverImage(url,cover_url.replace('/covers-full/', '/covers-large/'))[0] + if not cover_set or cover_set.startswith("failedtoload"): self.setCoverImage(url,cover_url) # some content is show as tables, this will preserve them