From 7c4e819c932f65530fe228d7772a406ce506c6b4 Mon Sep 17 00:00:00 2001 From: Jim Miller Date: Thu, 6 Apr 2023 12:03:21 -0500 Subject: [PATCH] Add comment about why cover not read from epub on update --- fanficfare/adapters/base_adapter.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/fanficfare/adapters/base_adapter.py b/fanficfare/adapters/base_adapter.py index 4c9fb3f1..92db416c 100644 --- a/fanficfare/adapters/base_adapter.py +++ b/fanficfare/adapters/base_adapter.py @@ -580,6 +580,18 @@ class BaseSiteAdapter(Requestable): #print("\n\ndescription:\n"+self.story.getMetadata('description')+"\n\n") def setCoverImage(self,storyurl,imgurl): + ## Why isn't explicitly set cover image cached/retrieved from + ## epub on update? + ## - CLI especially calls metadata collection before reading + ## update epub because it might need the title etc to find the + ## update file. + ## - setCoverImage(& therefore addImgUrl) called during metadata + ## collection so we know if cover download worked or not. + ## - Where would epub remember cover URL? cover.xhtml is the obvious place, but covers are poked more + ## than other images by other tools. + ## - Some users change the cover, but don't want to change first + ## image, may cause problems if cover orig url remembered. if self.getConfig('include_images'): logger.debug("setCoverImage(%s,%s)"%(storyurl,imgurl)) return self.story.addImgUrl(storyurl,imgurl,self.get_request_raw,cover=True,